Ensure that the git pre-processor doesn't accidentally bail also #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
commented
Mar 31, 2022
lib/cocoapods-downloader/git.rb
Outdated
| command = ['ls-remote', | ||
| '--', |
There was a problem hiding this comment.
-- was added to the version of git shipped with 2.25, but version 2.24 is still pretty actively used by default in osx as Apple Git-128 somewhere about 2 years ago - we shouldn't rely solely on the -- IMO
I'm trying to get an old git to test that this param is ignored ATM
dnkoutso
approved these changes
Mar 31, 2022
|
For 1-6-stable? |
|
Yes, I'll fix rubocop after I get an old git to check |
orta
force-pushed
the
validate_before_dl
branch
from
8677ac3
to
d27c983
Compare
|
Yep, good to go, confirmed the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in #127 moved everything into the
downloadpath (as all API consumers would have to use that eventually) butself.preprocess_optionscan get called before that (and independently of it) and so this handles that case.