Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bzr support #4

Merged
merged 5 commits into from
Sep 3, 2013
Merged

Bzr support #4

merged 5 commits into from
Sep 3, 2013

Conversation

fmccann
Copy link
Contributor

@fmccann fmccann commented Sep 3, 2013

Basic support for Bazaar repositories.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c02a2fb on fmccann:bzr_support into 7cfddec on CocoaPods:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 843f750 on fmccann:bzr_support into 7cfddec on CocoaPods:master.

@orta
Copy link
Member

orta commented Sep 3, 2013

🍻

@alloy
Copy link
Member

alloy commented Sep 3, 2013

Awesome.

One question, though, is it not common for people to use tags in the Bazaar world? And even if it’s not, I still think it would be better to have support for that too, unless there’s a specific reason not to?

@fmccann
Copy link
Contributor Author

fmccann commented Sep 3, 2013

I’m pretty sure that tags work as revisions with bzr, but I’ll try it out today and add it explicitly if it needs it.

On Sep 3, 2013, at 3:14 AM, Eloy Durán [email protected] wrote:

Awesome.

One question, though, is it not common for people to use tags in the Bazaar world? And even if it’s not, I still think it would be better to have support for that too, unless there’s a specific reason not to?


Reply to this email directly or view it on GitHub.

office: (207) 200-3415
mobile: (862) 204-9006

@alloy
Copy link
Member

alloy commented Sep 3, 2013

Thanks.

As far as I could tell tags are, like in many other systems, aliases to specific revisions, so they’re technically not needed. However, in our case the semantic value of these aliases is much more needed, as it allows people to easily see that a spec is using a revision that’s deemed special according to the lib’s author.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fc920ab on fmccann:bzr_support into 7cfddec on CocoaPods:master.

@fmccann
Copy link
Contributor Author

fmccann commented Sep 3, 2013

OK, I’ve added explicit support for a :tag option. There’s tests for tags supplied either via :tag or :revision and either works.

On Sep 3, 2013, at 7:47 AM, Eloy Durán [email protected] wrote:

Thanks.

As far as I could tell tags are, like in many other systems, aliases to specific revisions, so they’re technically not needed. However, in our case the semantic value of these aliases is much more needed, as it allows people to easily see that a spec is using a revision that’s deemed special according to the lib’s author.


Reply to this email directly or view it on GitHub.

office: (207) 200-3415
mobile: (862) 204-9006

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7901194 on fmccann:bzr_support into 7cfddec on CocoaPods:master.

@alloy
Copy link
Member

alloy commented Sep 3, 2013

Awesome, thanks!

alloy added a commit that referenced this pull request Sep 3, 2013
@alloy alloy merged commit 8bb9a80 into CocoaPods:master Sep 3, 2013
@fmccann fmccann deleted the bzr_support branch September 11, 2013 18:21
@alloy
Copy link
Member

alloy commented Sep 20, 2013

@fmccann Btw, are using this in conjunction with CocoaPods? If so, it would be great if you could take a look at implementing the Bazaar support for installing directly from a repo. For instance, a Podfile like this:

pod 'BazaarRepo', :bzr => 'URL'

@fmccann
Copy link
Contributor Author

fmccann commented Sep 20, 2013

I am using it, though for some private repositories for now. I'll take a look at implementing this feature.

On Sep 20, 2013, at 1:09 PM, Eloy Durán [email protected] wrote:

@fmccann Btw, are using this in conjunction with CocoaPods? If so, it would be great if you could take a look at implementing the Bazaar support for installing directly from a repo. For instance, a Podfile like this:

pod 'BazaarRepo', :bzr => 'URL'

Reply to this email directly or view it on GitHub.

@alloy
Copy link
Member

alloy commented Sep 20, 2013

Thanks. That’s what I figured you were doing and that’s also what I’m adding to the CHANGELOG for CocoaPods 0.25.0:

  • Partial support has been added for the Bazaar SCM. This allows specifications
    to use the :bzr option, but only when used from a spec repo.

    Patches to add support for external options, such as installing directly from
    a Bazaar repo, will be gladly accepted.

    Fred McCann
    #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants