[Git] Remove calls to Dir.chdir #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benasher44
reviewed
Oct 15, 2016
| end | ||
| options = {} | ||
| options[:git] = url | ||
| options[:commit] = `git -C #{target_path} rev-parse HEAD`.chomp |
There was a problem hiding this comment.
Add quotes around #{target_path}
|
@benasher44 👍 updated and added a 📝 entry. |
segiddins
reviewed
Oct 15, 2016
| @@ -15,7 +15,7 @@ def options_specific? | |||
| def checkout_options | |||
| options = {} | |||
| options[:git] = url | |||
| options[:commit] = `git -C #{target_path} rev-parse HEAD`.chomp | |||
| options[:commit] = `git -C "#{target_path}" rev-parse HEAD`.chomp | |||
There was a problem hiding this comment.
why not use git!("-C", target_path, "rev-parse", "HEAD") ?
There was a problem hiding this comment.
I assumed someone had used 's for a reason and didn't want to change that in this PR, can switch it to target_git` tho
|
@segiddins @benasher44 Updated |
endocrimes
added a commit
to CocoaPods/cocoapods-integration-specs
that referenced
this pull request
Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes CocoaPods/CocoaPods#5880