Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svn export use --ignore-externals option if specified :externals => false #8

Merged
merged 4 commits into from
Feb 6, 2014

Conversation

banjun
Copy link
Contributor

@banjun banjun commented Feb 6, 2014

Some svn repositories have svn:externals that refs to http:// URL.
svn export fails when I'm behind a http proxy that blocks HTTP PROPFIND, and that cause a failure at pod install. (such proxy is on my company network... 😟)

With --ignore-externals option, svn export and pod install succeed and I can separate svn:externals into pod's dependencies.

So I'd like to suggest :externals option like this:
s.source = { :svn => 'https://google-api-objectivec-client.googlecode.com/svn/trunk', :revision => 'r301', :externals => false }

For backward compatibility, svn downloader updates externals without :externals => false option.

Similar option for git submodules was merged here:
CocoaPods/CocoaPods#442

@alloy
Copy link
Member

alloy commented Feb 6, 2014

Very nice! Can you first add an entry to the CHANGELOG crediting yourself?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6ddf47e on banjun:svn-ignore-externals into 4a95877 on CocoaPods:master.

@alloy
Copy link
Member

alloy commented Feb 6, 2014

Hmm, it seems the Travis CI build has been failing since a recent change of mine, please ignore that.

@alloy
Copy link
Member

alloy commented Feb 6, 2014

Thanks!

alloy added a commit that referenced this pull request Feb 6, 2014
svn export use --ignore-externals option if specified :externals => false
@alloy alloy merged commit c1096b3 into CocoaPods:master Feb 6, 2014
@banjun banjun deleted the svn-ignore-externals branch February 6, 2014 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants