GI-19 Create Volunteer Page #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahekagg
approved these changes
Nov 9, 2023
hams7504
reviewed
Nov 9, 2023
hams7504
requested changes
Nov 9, 2023
| </BrowserRouter> | ||
| <BrowserRouter> | ||
| <Routes> | ||
| <Route path="/" element={<MapPage />} /> |
There was a problem hiding this comment.
Could you try adding this as a route: <Route path="/volunteer_page" element={<VolunteerPage />} />
There was a problem hiding this comment.
pushed changes for both comments; for Resources, I assumed you meant substituting BoxPanel with FlippableTile, since Resources represents a grid of tiles?
hams7504
approved these changes
Nov 12, 2023
| </a> | ||
| </div> | ||
| <Divider /> | ||
| <Resources /> |
There was a problem hiding this comment.
I think Resources can be replaced with Tiles.tsx and the volunteerResources.ts file could be removed.
JamesColesanti
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #75
📝 Description
Created the volunteer page in accordance with the Figma designs, including a map preview and "Resources" section
Briefly list the changes made to the code:
✔️ Verification
🏕️ (Optional) Future Work / Notes
To view this page, replace MapPage in main.tsx with VolunteerPage