feat: minimal implementation to support valibot #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MH4GF
changed the title
Closed
MH4GF
commented
May 31, 2024
| @@ -81,6 +82,7 @@ | |||
| "ts-dedent": "^2.2.0", | |||
| "ts-jest": "29.1.4", | |||
| "typescript": "5.4.5", | |||
| "valibot": "0.31.0-rc.6", | |||
There was a problem hiding this comment.
valibot is planning big breaking changes to its API in v.0.31.0. Since the old API is no longer available, this PR uses the rc version to comply with the new API.
MH4GF
commented
May 31, 2024
| return `v.boolean()`; | ||
| } | ||
| console.warn('unhandled scalar name:', scalarName); | ||
| return 'v.any()'; |
There was a problem hiding this comment.
Since no type errors occurred, definedNonNullAny was implemented without using it.
|
@Code-Hex Sorry for the delay, please review at your convenience! |
|
What a great job @MH4GF !! |
|
CI is down, so I'll merge the main branch 🏃🏻♂️ |
Code-Hex
reviewed
Jun 6, 2024
Comment on lines
+123
to
+125
| // This function generates `[v.minLength(100), v.email()]` | ||
| // NOTE: valibot's API is not a method chain, so it is prepared separately from buildApi. | ||
| // |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements valibot support.
First of all, only the contents of example/zod/schemas.ts are supported, not all configurations. Even at this point, the use case for my project can be met, and I plan to begin production operation when it is released.
Should documentation still be added in its current condition? I would like to discuss this.
After merging this PR, I will implement the test which is a todo.