Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

README.md update for docker #166

Merged
merged 3 commits into from
Jul 24, 2017
Merged

README.md update for docker #166

merged 3 commits into from
Jul 24, 2017

Conversation

BretFisher
Copy link
Member

Helps finish issue #142 with info on how to start from scratch, get the proper docker, and go go go!

Removed old non-docker instructions as this is now our default dev/deploy process and hopefully can be used by everyone to improve dev<->prod likeness.

README.md Outdated
1. `docker-compose --help` is your friend.
1. Use `docker-compose logs app` to see the node logs, for example.
1. Use `docker-compose exec app bash` to get a bash shell inside the running node container, for example. You can also do that against `db` so you can use the `psql` tool against the database interactively.
1. To just run a one off psql command, you could do something like this from your host shell: `
Copy link
Member

@wbprice wbprice Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally the instructions.

README.md Outdated

Assuming your using `docker-compose`, if nothing is currently up, then you can run tests in a new container with `docker-compose run app npm test`. If you've already started the containers with something like `docker-compose up -d` then you can run tests in that same container with `docker-compose exec app npm test`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"you're"

Copy link
Member

@wbprice wbprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall, but include directions on how to use psql.

@BretFisher
Copy link
Member Author

updated to fix both issues

@wbprice wbprice merged commit 20f9b78 into Code4HR:develop Jul 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants