Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Setup #1

Merged
merged 16 commits into from
Oct 23, 2021
Merged

[Chore] Setup #1

merged 16 commits into from
Oct 23, 2021

Conversation

gertie-sheshe
Copy link
Contributor

@gertie-sheshe gertie-sheshe commented Oct 18, 2021

Description

Project Setup

Type of change

Please delete options that are not relevant.

  • Chore (non-breaking change which does not add visible functionality but improves code quality)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾


  1. Start with full up-to-date dependencies
    Screenshot from 2021-10-18 14-37-59
  2. If warning about missing dependency can be added, lets add it
    Screenshot from 2021-10-18 14-37-49
  3. Ensure storybook is configured properly (header.html for importing google fonts, viewports in the preview, etc. etc. etc.).

.babelrc Outdated Show resolved Hide resolved
jsconfig.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾


Still missing a lot of dev dependencies... put another way, the only dependency warnings that should be there are those about react and jscodeshit. This is because we're using newer versions than those expected.

There shouldn't e any other warning... especially about eslint, @storybook/xxx, webpack, etc.

README.md Outdated Show resolved Hide resolved
src/pages/_app.js Outdated Show resolved Hide resolved
src/pages/_document.js Show resolved Hide resolved
src/theme/index.js Outdated Show resolved Hide resolved
@gertie-sheshe
Copy link
Contributor Author

@kilemensi could you please share a screenshot of the dependency warnings you are getting. I do not have them

@kilemensi
Copy link
Member

@kilemensi could you please share a screenshot of the dependency warnings you are getting. I do not have them

You do have them @gertie-sheshe ... original screenshot linked here and if you do something like yarn upgrade on current PR, you should get 👇🏾

Screenshot from 2021-10-21 11-25-24

@gertie-sheshe
Copy link
Contributor Author

I already did a yarn upgrade after the first screenshot @kilemensi , right now if you run yarn outdated this is what you have... Screenshot 2021-10-22 at 07 46 46

@gertie-sheshe
Copy link
Contributor Author

gertie-sheshe commented Oct 22, 2021

Fixed all the warning issues aside from eslint. The packages with warnings still depend on eslint 7.x and below while eslint has upgraded to v8. As you can see here and here PRs for these fixes in the respective packages are still open. We can make the update afterwards. @kilemensi

@kilemensi
Copy link
Member

Fixed all the warning issues aside from eslint. The packages with warnings still depend on eslint 7.x and below while eslint has upgraded to v8. As you can see here and here PRs for these fixes in the respective packages are still open. We can make the update afterwards. @kilemensi

Cool, cool... lets forge ahead then @gertie-sheshe

@gertie-sheshe gertie-sheshe merged commit 137d747 into main Oct 23, 2021
@kilemensi kilemensi deleted the chore/setup branch November 11, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants