-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6/OrlandoMorales/HTML&CSS/BikesForRefugees/Week1 #470
base: main
Are you sure you want to change the base?
NW6/OrlandoMorales/HTML&CSS/BikesForRefugees/Week1 #470
Conversation
✅ Deploy Preview for cyf-bfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good work. Just a little comment. When I hover on the links on the header, the background should be white not block
</div> | ||
|
||
<div> | ||
<h2 class="heading-underline">Learn more</h2> | ||
|
||
<div> | ||
<div class="articleArea"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For many of these <div>
elements that have a class similar to article
, have a look through these semantic HTML elements and see if there is one that fits. It is very similar to the name already in these classes!
@@ -87,7 +88,7 @@ <h3 class="article__title">Why do refugees need bikes?</h3> | |||
</p> | |||
</div> | |||
|
|||
<div class="article"> | |||
<div class="article1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see <div>
elements on the page with very similar (but not quite identical) classes, for example, articleArea
, article
, articles
. Classes are used where we want to style multiple elements in a similar way. IDs are used when there is only one element that should be styled. Have a think about whether these elements with "article"-like classes should all have the same class or not
I did some additions and substraction in HTML and CSS to try to make the website looks like the task