Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings broken with Gutenberg 6.8.0 #892

Closed
fbertram opened this issue Nov 1, 2019 · 4 comments
Closed

Headings broken with Gutenberg 6.8.0 #892

fbertram opened this issue Nov 1, 2019 · 4 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@fbertram
Copy link

fbertram commented Nov 1, 2019

Description: After upgrading to Gutenberg 6.8.0, all heading blocks return the message "This block has encountered an error and cannot be previewed.".

How to reproduce:

  1. fresh install of WordPress v5.2.4 (I am using a Docker-based install on localhost)
  2. remove all plugins (Akismet, Dolly)
  3. install and activate Neve theme v2.4.3
  4. remove all other themes (2016 - 2019)
  5. edit 'Privacy Policy' page => everything seems to be ok
  6. install and activate Gutenberg plugin v6.8.0
  7. edit 'Privacy Policy' page => Heading blocks no longer show but display 'This block has encountered an error and cannot be previewed.' Please note that the page renders fine, even with the blocks displaying errors.
  8. downgrade Gutenberg plugin to v6.7.0
  9. edit 'Privacy Policy' page => everything works fine again.

Expected behaviour:

With Gutenberg 6.8.0, headings should be editable, and not display an error message.

Current behaviour:

Headings cannot be edited, show error message "This block has encountered an error [...]"

Reference:

This might be linked to the following issue w/ Gutenberg: WordPress/gutenberg#18232

Technical info

  • WordPress version: x5.2.4
  • Gutenberg 6.8.0
  • Theme version: Neve 2.4.3
@fbertram
Copy link
Author

fbertram commented Nov 2, 2019

it seems the issue can be solved with a minor edit: in Neve's inc/core/front_end.php:

change: add_theme_support( 'editor-color-palette', $this->get_gutenberg_color_palette() );
to: add_theme_support( 'editor-color-palette', array() );

Not sure which side-effects this might have.

@selul selul added the bug This label could be used to identify issues that are caused by a defect in the product. label Nov 2, 2019
@selul
Copy link
Contributor

selul commented Nov 2, 2019

@fbertram thanks for reporting.

We will look into this !

@alcarazzam
Copy link

Confirmed with the same versions of @fbertram and a child theme of Neve.

selul added a commit that referenced this issue Nov 4, 2019
fix: reset array keys for gutenberg editor palette [fixes #892]
@selul
Copy link
Contributor

selul commented Nov 4, 2019

@fbertram @m-alzam we have found the glitch, the next version will include the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

No branches or pull requests

3 participants