Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line chart color options not working as expected. [in visualizer block options only] #925

Closed
kushh23 opened this issue Aug 20, 2022 · 1 comment · Fixed by #929 or #932
Closed

Line chart color options not working as expected. [in visualizer block options only] #925

kushh23 opened this issue Aug 20, 2022 · 1 comment · Fixed by #929 or #932
Labels
bug This label could be used to identify issues that are caused by a defect in the product. doc-created This label will be used after the doc-needed request has been satisfied. doc-needed This issue requires documentation updates or additions once it has been completed. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@kushh23
Copy link

kushh23 commented Aug 20, 2022

Description:

When you try to change the Horizontal axis base line color using color settings, it is not respecting the color choice and shows zero effect and when you change the color of the vertical axis base line, it changes the color of the horizontal axis instead of its own axis.

I also noticed that when you use the default color options given in settings, the color is not changing but when you pick the color using a color picker the changes are made easily. [this is happening in block options only ]

How to reproduce the Axis base line color issue :

  1. Go to the visualizer menu and create a new line (or column) chart.
  2. Go to a page /post and add a new block chart.
  3. Use the existing chart that you created in the first step.
  4. Go to Block settings > Advanced options > Horizontal axis settings > base line color.
  5. Try to change the color of the base line.
  6. Observe that nothing changes.
  7. Now navigate to Vertical axis settings > base line color
  8. Try to change the color of the base line.
  9. Observe that changes are being made but in the Horizontal axis base line instead of the vertical axis.

How to reproduce the default color option issue :

  1. Go to the visualizer menu and create a new line (or column) chart.
  2. Go to a page /post and add a new block chart.
  3. Use the existing chart that you created in the first step.
  4. Go to Block settings > Advanced options > Horizontal axis settings > Axis Text color [same for vertical axis settings].
  5. Try to change the color using default color options.
  6. Observe that Nothing changes.
  7. Now try to change the color using the color picker option.
  8. Changes are being made.

Expected behavior:

  • The color of the horizontal axis base line should be changed using the color options available in horizontal axis settings.
  • The color option of the vertical axis setting should change the color of vertical axis base line instead of the horizontal axis base line.
  • The axis text color should be changed using the default color options.

Current behavior:

  • The color of the horizontal axis base line is not changing at all using the horizontal axis settings.
  • The color settings of the vertical axis are interfering with the horizontal axis and changing its base line color instead of its own
  • The axis text color is changed only using a color picker [default color options not working ]

Reference:

Screenshots for the first bug :
Screenshot_4
Screenshot_9

Loom video for the first bug :
https://www.loom.com/share/e0ddeb2c89884920ac9f9f31259a4915

Screenshot for the second bug :
Screenshot_6
Screenshot_5

Technical info

  • WordPress version: 6.0.1
  • Visualizer version: 3.7.10
girishpanchal30 added a commit that referenced this issue Aug 23, 2022
@girishpanchal30
Fix update axis baseline color #925
aed1bf9
@girishpanchal30 girishpanchal30 mentioned this issue Aug 23, 2022
Merged
@girishpanchal30 girishpanchal30 linked a pull request Aug 23, 2022 that will close this issue
Fix update axis baseline color #929
Merged
@girishpanchal30 girishpanchal30 added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 23, 2022
girishpanchal30 added a commit that referenced this issue Aug 23, 2022
@girishpanchal30
Fix select color from neve color palette #925
5d15462
@vytisbulkevicius vytisbulkevicius mentioned this issue Aug 29, 2022
Merged
@vytisbulkevicius vytisbulkevicius linked a pull request Aug 29, 2022 that will close this issue
Release #932
Merged
@vytisbulkevicius vytisbulkevicius added the doc-needed This issue requires documentation updates or additions once it has been completed. label Aug 29, 2022
vytisbulkevicius added a commit that referenced this issue Aug 30, 2022
@vytisbulkevicius
release: fixes
7584e7d 
- Fix update axis baseline color #925 
- Update more features images #926
- Fix update minor grid line field #924 
- Add new filter for container attributes #922 
- Fix axis data format issue #920 
- Chart unique title #915 
- Fix block back button issue #930 
- Userguide broken documentation link #918
pirate-bot pushed a commit that referenced this issue Aug 30, 2022
chore(release): 3.7.11
fe73598 
##### [Version 3.7.11](v3.7.10...v3.7.11) (2022-08-30)

- Fix update axis baseline color [#925](#925)
- Update more features images [#926](#926)
- Fix update minor grid line field [#924](#924)
- Add new filter for container attributes [#922](#922)
- Fix axis data format issue [#920](#920)
- Chart unique title [#915](#915)
- Fix block back button issue [#930](#930)
- Userguide broken documentation link [#918](#918)
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.7.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 30, 2022
@AndreeaCristinaRadacina AndreeaCristinaRadacina added the doc-created This label will be used after the doc-needed request has been satisfied. label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This label could be used to identify issues that are caused by a defect in the product. doc-created This label will be used after the doc-needed request has been satisfied. doc-needed This issue requires documentation updates or additions once it has been completed. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix update axis baseline color Codeinwp/visualizer
Release Codeinwp/visualizer
5 participants
@vytisbulkevicius @pirate-bot @girishpanchal30 @AndreeaCristinaRadacina @kushh23