Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Review Guidelines to Exclude Comments #327

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Update Review Guidelines to Exclude Comments #327

merged 1 commit into from
Sep 25, 2023

Conversation

mrT23
Copy link
Collaborator

@mrT23 mrT23 commented Sep 25, 2023

PR Type:

Documentation


PR Description:

This PR updates the review guidelines in two configuration files. The changes specify that reviewers should not suggest adding docstrings, type hints, or comments to the code. This update is reflected in both 'pr_code_suggestions_prompts.toml' and 'pr_reviewer_prompts.toml' files.


PR Main Files Walkthrough:

files:

pr_agent/settings/pr_code_suggestions_prompts.toml: The instructions for code suggestions have been updated to include 'comments' in the list of items that should not be suggested for addition.
pr_agent/settings/pr_reviewer_prompts.toml: The review guidelines have been updated to specify that reviewers should not suggest adding docstrings, type hints, or comments.

@mrT23
Copy link
Collaborator Author

mrT23 commented Sep 25, 2023

/describe

@github-actions github-actions bot changed the title no comments Update Review Guidelines to Exclude Comments Sep 25, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 25, 2023
@github-actions
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Updating instructions for PR reviewers and code suggestion prompts
  • 📝 PR summary: This PR updates the instructions for PR reviewers and code suggestion prompts to include a directive not to suggest adding comments, in addition to the existing directives not to suggest adding docstrings or type hints.
  • 📌 Type of PR: Documentation
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 1
    The PR is straightforward and involves only text changes in instructions. No code or logic has been altered.
  • 🔒 Security concerns: No

PR Feedback

  • 💡 General suggestions: The changes made in the PR are clear and straightforward. However, it would be beneficial to provide a rationale for not suggesting comments in the PR. This could help contributors understand the reasoning behind this guideline.

  • 🤖 Code feedback:

    • relevant file: pr_agent/settings/pr_code_suggestions_prompts.toml
      suggestion: Consider adding a rationale for not suggesting comments in the PR. This could be done by appending a sentence explaining the reasoning behind this guideline. [medium]
      relevant line: Don't suggest to add docstring, type hints, or comments.

    • relevant file: pr_agent/settings/pr_reviewer_prompts.toml
      suggestion: Similar to the previous suggestion, consider adding a rationale for not suggesting comments in the PR. This could be done by appending a sentence explaining the reasoning behind this guideline. [medium]
      relevant line: - Don't suggest to add docstring, type hints, or comments.

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@mrT23 mrT23 added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Sep 25, 2023
@mrT23 mrT23 merged commit ba78475 into main Sep 25, 2023
3 checks passed
@mrT23 mrT23 deleted the tr/no_comments branch September 25, 2023 14:25
yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024
Update Review Guidelines to Exclude Comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant