Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete to EventRepository #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sebdeveloper6952
Copy link

@sebdeveloper6952 sebdeveloper6952 commented Apr 4, 2024

This PR adds a delete method to the EventRepository interface. An implementation of the method is also provided on EventRepositorySqlite.

Addresses #18

@sebdeveloper6952
Copy link
Author

@CodyTseng I repeated a lot of code here, I will improve it, just wanted to get the PR going. I think the find and delete methods could share the filtering logic and we could extract that into its own function that returns an object like:

{
  innerJoinClauses: [],
  whereClauses: [],
  whereValues: []
}

@CodyTseng
Copy link
Owner

Sounds good!

@sebdeveloper6952 sebdeveloper6952 changed the title wip: adds delete method with repeated filter code Add delete to EventRepository Apr 9, 2024
@sebdeveloper6952 sebdeveloper6952 marked this pull request as ready for review April 9, 2024 07:35
@sebdeveloper6952
Copy link
Author

Hi @CodyTseng, what do you think of this so far?

@CodyTseng
Copy link
Owner

Hi @CodyTseng, what do you think of this so far?

It seems like the tag filtering condition is ineffective 🤔

@sebdeveloper6952
Copy link
Author

Hi @CodyTseng, what do you think of this so far?

It seems like the tag filtering condition is ineffective 🤔

I'll check that out and also provide test cases in this PR.

@CodyTseng
Copy link
Owner

I'll check that out and also provide test cases in this PR.

No hurry, take your time 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants