Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: At the request of #593 #635

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: At the request of #593 #635

wants to merge 2 commits into from

Conversation

dannima
Copy link
Contributor

@dannima dannima commented Apr 20, 2018

Try to solve #593
Remove join function in utilities/StringUtils.java, use StringUtils.join in Apache common

Copy link

@cogcomp-dev cogcomp-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & thorough -- but please add a unit test that verifies the behavior is now correct.

@cogcomp-dev
Copy link

@dannima any progress on this? build is failing -- looks like a missing dependency. Also, please a unit test to verify behavior if one does not exist already (in which case, identify the test class).

@dannima dannima changed the title At the request of #593 WIP: At the request of #593 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants