Question type classification #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhargav
approved these changes
Dec 22, 2016
|
It seems I do not have write access and permission to merge? @bhargav |
|
@kordjamshidi Strange. You had |
|
I see that I have the permissions now, thanks. This was not the case the other day. |
Rahgooy
reviewed
Feb 14, 2017
| @@ -245,7 +245,7 @@ trait DataModel extends Logging { | |||
| def apply(f: T => List[String])(implicit tag: ClassTag[T], d1: DummyImplicit, d2: DummyImplicit, d3: DummyImplicit, | |||
| d4: DummyImplicit, d5: DummyImplicit, d6: DummyImplicit): DiscreteCollectionProperty[T] = { | |||
| def cachedF = if (cache) { x: T => getOrUpdate(x, f).asInstanceOf[List[String]] } else f | |||
| val a = new DiscreteCollectionProperty[T](name, cachedF, ordered) with NodeProperty[T] { | |||
| val a = new DiscreteCollectionProperty[T](name, cachedF, !ordered) with NodeProperty[T] { | |||
There was a problem hiding this comment.
@danyaljj why the order negated here?
There was a problem hiding this comment.
This is a bug that existed in the system from a long time ago and I noticed it when I was making these changes (also mention in #454).
But fixing it required retraining systems, which at the time I didn't have time to do it. So I left it as an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding application: Question Type Classification. Details in the readme.