Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar added to learn and populate functions #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Progress bar added to learn and populate functions #485

wants to merge 1 commit into from

Conversation

Rahgooy
Copy link
Collaborator

@Rahgooy Rahgooy commented Aug 18, 2017

targets issue #452

@danyaljj
Copy link
Member

Thanks Taher!
Do you have an screenshot?
Also, did you test it for JointTraining?

@Rahgooy
Copy link
Collaborator Author

Rahgooy commented Aug 18, 2017

Sure,
image

and about your second question, no I didn't test it with joint train

@danyaljj
Copy link
Member

Screenshot: Looks good. Thanks.

kordjamshidi
kordjamshidi reviewed Aug 29, 2017
View reviewed changes
Copy link
Member

@kordjamshidi kordjamshidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too.

@kordjamshidi
Copy link
Member

kordjamshidi commented Aug 29, 2017 •
edited
Loading

regarding the jointraining comment, I don't think this is working for that since the training goes through a different object JointTrainSparseNetwork, but tis progress bar is placed only in learnable. @Rahgooy @danyaljj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kordjamshidi kordjamshidi kordjamshidi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rahgooy @danyaljj @kordjamshidi