Properties: some improvements

[danyaljj]

With this PR the new definitions for properties should be fully functional. Also,

• Adds unit tests for properties: issue how to test properties?  #50

Note: I still need to remove the old property definitions and change the core and existing instances accordingly. I will do these in another PR. And fixing the naming patterns inside the properties( issue #33 ) for another PR.

[kordjamshidi]

@danyaljj : Is your last PR working really?
I have this code

val listIntAttributeArrayOldWay = property[Document]("listInt") {
    x: Document => List(1)
  }
}

and then this :

val x6=listIntAttributeArrayOldWay(tests.head)

does not compile where tests.head is a Document
however this old version is working instead:

val listIntAttributeArrayOldWay = intAttributesArrayOf[Document]('listInt) {
    x: Document => List(1)
  }

[danyaljj]

@kordjamshidi @christos-c @sameersingh This PR is ready for review. Comments are welcome!

[kordjamshidi]

Have you run an example with mixed features?

[danyaljj]

No, any problem?

[danyaljj]

@kordjamshidi have you noticed any issue?

[danyaljj]

@kordjamshidi I have this unit test in which I test all of the properties.

[kordjamshidi]

I think it just did not work, even in Lbjava.

[danyaljj]

What file? Where? What is the error?

[kordjamshidi]

I have not run it to see what is the error, but I guess the mixed attributes should be checked as those did not work. You can try an example in Lbjava first. I guess the code in this file: saul/saul-core/src/main/scala/edu/illinois/cs/cogcomp/saul/datamodel/attribute/CombinedDiscreteAttribute.scala
and also RelationalFeatures in the same location should be relevant to this.

[kordjamshidi]

@danyaljj , does this version work when calling properties on instances? I need a working version, and I am going to accept this PR if this is working-- because your previous PR does not work.

[danyaljj]

As I mentioned it removes a bug I had in the previous version.
And you can see I have a unit test for properties in which all of them pass.
If you see a new bug, you should let me know. Otherwise, I won't notice it.

[kordjamshidi]

Sorry if I miss something here, it would be helpful if you point me to the place in your test unit that calls the property by its name and directly applies on an instance like the example I mentioned:
listIntAttributeArrayOldWay(tests.head)

[danyaljj]

I am coming to your office!

[kordjamshidi]

This is ok for me to merge now.