Keyboard shortcuts for 'Accept/Revert url/test' buttons #360
Conversation
| @@ -60,14 +62,16 @@ define(['angularAMD', 'userSettingsService'], function (angularAMD) { | |||
| }, | |||
| '221': function () { | |||
| scope.traverseTree('down'); | |||
| } | |||
| }, | |||
| '65': accept, | |||
There was a problem hiding this comment.
Great job!
What do you think, maybe we could remember ASCII codes in variables instead of add comment?
There was a problem hiding this comment.
Actually we don't need to use ASCII codes at all and we can use event.key property instead of event.keyCode which is returning single character that identify keyboard buttons. I added new shortcuts using existing convention. If it is necessarily I can quick refactor it.
| @@ -3410,6 +3410,9 @@ It is possible to search tests and URLs by the query. Searched fields are the UR | |||
| * use **[** / **]** to navigate between test's urls | |||
| * press **m** to show/hide layout mask (when available) | |||
| * press **←** / **→** to navigate between url's tabs | |||
| * press **a** for accepting suite/test/url | |||
There was a problem hiding this comment.
Please update only SuiteReportFeatures.md. I think that it isn't a good idea to update historical documentation ;)
| } | ||
|
|
||
| function accept(event) { | ||
| clickButton('.button-blue', event); |
There was a problem hiding this comment.
I'm not sure that this is correct assumption, that element with class button-blue should be clicked on the accept event (the same for the button-red). More buttons also have those classes, e.g.:
Maybe buttons for accepting/reverting should have their own identifiers?
There was a problem hiding this comment.
Assumption is that only buttons inside toolbar-bottom or tab-content-toolbar will be clicked (function clickButton is looking for those classes first and then looking in their child nodes proper buttons for click). "Save all changes" button is inside sidepanel so it will not be clicked.
Added Ids for buttons for better identification
tkaik
added
the
QA Required
|
tested, working well ✔️ |
Description
Motivation and Context
#317
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.