URL rerun #517
Merged
URL rerun #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2019 09:01
tkaik
reviewed
Aug 1, 2019
| @@ -35,7 +35,7 @@ <h4 class="toolbar-link-header ellipsis"> | |||
| data-content="Rerun current URL" | |||
| data-trigger="hover" | |||
| data-container="body" | |||
| data-ng-click="toolbarBottom.rerunURL(toolbarBottom.model.url)"> | |||
| data-ng-click="toolbarBottom.rerunURL(toolbarBottom.model.name)"> | |||
There was a problem hiding this comment.
Will it also work when URL doesn't have a "name" attribute in XML?
There was a problem hiding this comment.
Yes, because when user doesn't set "Name" attribute, then URL is set as "Name"
plutasnyy
reviewed
Aug 7, 2019
| var url = endpointConfiguration.getEndpoint().getUrl + 'suite-rerun?' + rerunParams; | ||
| $http.post(url, {}).then(function successCallback(response) { | ||
| var url = endpointConfiguration.getEndpoint().getUrl + 'suite-rerun'; | ||
| $http.post(url, { |
tkaik
reviewed
Aug 8, 2019
| private String testUrl; | ||
| private String testName; | ||
|
|
||
| public RerunDataWrapper(String correlationId, String company, String project, String suite, String testUrl, String testName) { |
There was a problem hiding this comment.
This constructor is probably redundant, I don't think that GSON is using it. Setters are also redudant here
tkaik
reviewed
Aug 8, 2019
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ All notable changes to AET will be documented in this file. | |||
| - [PR-489](https://github.com/Cognifide/aet/pull/489) Cleaner integration tests | |||
| - [PR-480](https://github.com/Cognifide/aet/pull/480) Test summary stats on the main report page. ([#474](https://github.com/Cognifide/aet/issues/474)) | |||
| - [PR-459](https://github.com/Cognifide/aet/pull/459) Print more meaningful error messages when suite.xml is malformed ([#436](https://github.com/Cognifide/aet/issues/436)) | |||
| - [PR-517](https://github.com/Cognifide/aet/pull/517) Angular sends a URL name instead of a URL to RerunServlet ([#487](https://github.com/Cognifide/aet/issues/487)) | |||
There was a problem hiding this comment.
I suggest simplifying this, e.g. Single URL rerun fixed for named URLs so it's more understandable :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Angular app was sending a url instead of a url name, so backend could not find the right test case.
Motivation and Context
Closes #487
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.