Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL rerun #517

Merged
merged 7 commits into from
Aug 9, 2019
Merged

URL rerun #517

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9447118
fix url rerun
Aug 1, 2019
037ace0
changelog update
Aug 1, 2019
7556081
Bad-request status when cannot rerun test
Cich0sza Aug 1, 2019
27e255c
Finding Url object by url
Cich0sza Aug 7, 2019
7dac4ce
fixup! Finding Url object by url
Cich0sza Aug 7, 2019
2312f50
Add sending post data in body
Cich0sza Aug 7, 2019
d674df9
Update CHANGELOG.md
Cich0sza Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ All notable changes to AET will be documented in this file.
- [PR-489](https://github.com/Cognifide/aet/pull/489) Cleaner integration tests
- [PR-480](https://github.com/Cognifide/aet/pull/480) Test summary stats on the main report page. ([#474](https://github.com/Cognifide/aet/issues/474))
- [PR-459](https://github.com/Cognifide/aet/pull/459) Print more meaningful error messages when suite.xml is malformed ([#436](https://github.com/Cognifide/aet/issues/436))
- [PR-517](https://github.com/Cognifide/aet/pull/517) Angular sends a URL name instead of a URL to RerunServlet ([#487](https://github.com/Cognifide/aet/issues/487))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest simplifying this, e.g. Single URL rerun fixed for named URLs so it's more understandable :)


## Version 3.2.2

Expand Down
2 changes: 1 addition & 1 deletion report/src/main/webapp/app/layout/toolbar/toolbarBottom.view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h4 class="toolbar-link-header ellipsis">
data-content="Rerun current URL"
data-trigger="hover"
data-container="body"
data-ng-click="toolbarBottom.rerunURL(toolbarBottom.model.url)">
data-ng-click="toolbarBottom.rerunURL(toolbarBottom.model.name)">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it also work when URL doesn't have a "name" attribute in XML?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because when user doesn't set "Name" attribute, then URL is set as "Name"

<i class="far fa-play-circle fa-sm"></i>
</div>
<div ng-if="toolbarBottom.viewMode == 'suite' && toolbarBottom.isLastSuiteVersion"
Expand Down