Feat/polkadex v2 #366
Closed
Feat/polkadex v2 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #43708: Send Polkadex V2 connector to the Foundation. |
- Removes unused method - Adds test case
geneuinely07
added
the
foundation
- Removes testnet which is currently not supported
rxlxrxsx
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Tested and confirmed working by QA.
- Successfully cloned and installed the branch
- Connected seed phrase and confirmed working as expected
- Confirmed wallet and exchange balances are reflecting correct
- Created a pure_mm strategy and went through initial prompts successfully
- Started the strategy without issues, confirmed orders are created and cancelled based on config
- Confirmed order book prices is in sync with the exchange
- Trade information are correct based on history command output
- Compared trades in client and exchange, no discrepancies found
- Confirmed hanging order/cancellation and multiple order levels works as expected
|
Closing to re-open towards foundation: hummingbot#6558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR introduces an update to the Polkadex connector to use the V2 API.
Tests performed by the developer:
Tips for QA testing:
Note that every now and then, the periodic order status update may fail because it happened immediately after submitting an order. Since Polkadex is a decentralized exchange, it takes a couple of seconds for the order to make it onto the chain and to become available for order status updates.
@CoinAlpha/qa-client, I am currently getting a segfault several seconds into using the OSS client. I've pinged Federico to check if that's a known issue on their end.
[ch-43708]