Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue tab infinite scroll #501

Merged
merged 5 commits into from
Aug 18, 2024
Merged

Conversation

huchenlei
Copy link
Member

Closes #496

Currently when queue tab is mounted (Tab expanded), it tries to load all preview images at once, which can freeze the browser if the images are large and numbers are large. This PR makes the preview images only load if the user scroll has reached there.

infiniteScroll.mp4

Note

The item per page is hard coded to 8 for now.

Copy link

socket-security bot commented Aug 18, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@vueuse/[email protected] environment, network Transitive: filesystem +4 1.99 MB vueuse-bot

View full report↗︎

@huchenlei huchenlei merged commit 9d3ca76 into Comfy-Org:main Aug 18, 2024
4 checks passed
@huchenlei huchenlei deleted the infiniteScroll branch August 18, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: High memory usage/freezing the browser when opeaning the queue/history with too many previews
1 participant