Skip to content

Commit

Permalink
[web/desktop] Make media overlay non-draggable
Browse files Browse the repository at this point in the history
Summary:
[ENG-4655](https://linear.app/comm/issue/ENG-4655)

According to this [issue](electron/electron#741), `-webkit-app-region: drag` (which is used for header dragging of the window) eats all events even for elements which defined outside of the header and just overlap with it.

The fix is to apply `-webkit-app-region: no-drag` to the multimedia overlay (we already apply it to the wordmark and navigation arrows).

Test Plan:
- Tested if clicking on the black overlay closed the image, both in inside header and outside
- Tested if close button closed the overlay, and if the cursor pointer correctly changed when hovering
- Tested if window wasn't draggable with overlay, and if it was draggable without overlay
- Tested if navigation arrows still worked (without overlay)

Reviewers: kamil, tomek, inka, patryk

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D8848
  • Loading branch information
MichalGniadek committed Aug 18, 2023
1 parent df101e5 commit 196da0d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions web/media/media.css
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ div.multimediaModalOverlay {
box-sizing: border-box;
display: flex;
justify-content: center;
-webkit-app-region: no-drag;
}
div.multimediaModalOverlay > .mediaContainer {
display: flex;
Expand Down

0 comments on commit 196da0d

Please sign in to comment.