[lib] rename userSupportsThickThreads -> userHasDeviceList

Summary: [ENG-9394](https://linear.app/comm/issue/ENG-9394/create-a-thick-thread-when-possible-while-searching-for-a-personal) Previous name was incorrect, user supports thick thread when is registered to Identity. Depends on D13487 Test Plan: Flow Reviewers: ashoat, tomek Reviewed By: ashoat Differential Revision: https://phab.comm.dev/D13488
CommE2E · Sep 30, 2024 · 2b2293c · 2b2293c
1 parent f1a29a5
commit 2b2293c
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 24 deletions.
diff --git a/lib/hooks/relationship-hooks.js b/lib/hooks/relationship-hooks.js
@@ -12,7 +12,7 @@ import { pendingToRealizedThreadIDsSelector } from '../selectors/thread-selector
 import { dmOperationSpecificationTypes } from '../shared/dm-ops/dm-op-utils.js';
 import { useProcessAndSendDMOperation } from '../shared/dm-ops/process-dm-ops.js';
 import {
-  userSupportsThickThreads,
+  userHasDeviceList,
   getPendingThreadID,
 } from '../shared/thread-utils.js';
 import type { RelationshipOperation } from '../types/messages/update-relationship.js';
@@ -123,10 +123,7 @@ function useUpdateRelationships(): (
       }
       const planForUsers = new Map<string, RobotextPlanForUser>();
       for (const userID of userIDs) {
-        const supportsThickThreads = userSupportsThickThreads(
-          userID,
-          auxUserInfos,
-        );
+        const supportsThickThreads = userHasDeviceList(userID, auxUserInfos);
         if (!supportsThickThreads) {
           planForUsers.set(userID, { plan: 'send_to_thin_thread' });
           continue;
@@ -266,10 +263,7 @@ function useUpdateRelationships(): (
     }
     const { action, userIDs, waitingForUserIDs, resolve, reject } = step;
     for (const userID of waitingForUserIDs) {
-      const supportsThickThreads = userSupportsThickThreads(
-        userID,
-        auxUserInfos,
-      );
+      const supportsThickThreads = userHasDeviceList(userID, auxUserInfos);
       if (!supportsThickThreads) {
         // It's safe to wait until every single user ID in waitingForUserIDs
         // passes this check because we make the same check when populating
@@ -313,10 +307,7 @@ function useUpdateRelationships(): (
 
       const missingDeviceListsUserIDs: Array<string> = [];
       for (const userID of userIDs) {
-        const supportsThickThreads = userSupportsThickThreads(
-          userID,
-          auxUserInfos,
-        );
+        const supportsThickThreads = userHasDeviceList(userID, auxUserInfos);
         if (!supportsThickThreads) {
           missingDeviceListsUserIDs.push(userID);
         }

diff --git a/lib/shared/dm-ops/dm-op-utils.js b/lib/shared/dm-ops/dm-op-utils.js
@@ -50,7 +50,7 @@ import type { ClientUpdateInfo } from '../../types/update-types.js';
 import { getContentSigningKey } from '../../utils/crypto-utils.js';
 import { useSelector } from '../../utils/redux-utils.js';
 import { messageSpecs } from '../messages/message-specs.js';
-import { userSupportsThickThreads } from '../thread-utils.js';
+import { userHasDeviceList } from '../thread-utils.js';
 import { updateSpecs } from '../updates/update-specs.js';
 
 function generateMessagesToPeers(
@@ -137,10 +137,7 @@ function useCreateMessagesToPeersFromDMOp(): (
     (userIDs: $ReadOnlyArray<string>) => {
       const missingDeviceListsUserIDs: Array<string> = [];
       for (const userID of userIDs) {
-        const supportsThickThreads = userSupportsThickThreads(
-          userID,
-          auxUserInfos,
-        );
+        const supportsThickThreads = userHasDeviceList(userID, auxUserInfos);
         if (!supportsThickThreads) {
           missingDeviceListsUserIDs.push(userID);
         }

diff --git a/lib/shared/search-utils.js b/lib/shared/search-utils.js
@@ -7,7 +7,7 @@ import SearchIndex from './search-index.js';
 import {
   getContainingThreadID,
   userIsMember,
-  userSupportsThickThreads,
+  userHasDeviceList,
 } from './thread-utils.js';
 import {
   searchMessagesActionTypes,
@@ -165,7 +165,7 @@ function usePotentialMemberItems({
       return !!(
         threadType &&
         threadTypeIsThick(threadType) &&
-        !userSupportsThickThreads(userID, auxUserInfos)
+        !userHasDeviceList(userID, auxUserInfos)
       );
     },
     [auxUserInfos, excludeUserIDs, threadType],

diff --git a/lib/shared/thread-actions-utils.js b/lib/shared/thread-actions-utils.js
@@ -6,7 +6,7 @@ import {
   threadIsPending,
   threadOtherMembers,
   pendingThreadType,
-  userSupportsThickThreads,
+  userHasDeviceList,
 } from './thread-utils.js';
 import {
   newThreadActionTypes,
@@ -138,7 +138,7 @@ async function createRealThreadFromPendingThread({
       'otherMemberIDs should not be empty for threads',
     );
     const allUsersSupportThickThreads = otherMemberIDs.every(memberID =>
-      userSupportsThickThreads(memberID, auxUserInfos),
+      userHasDeviceList(memberID, auxUserInfos),
     );
     if (threadTypeIsThick(threadInfo.type) && allUsersSupportThickThreads) {
       const type = assertThickThreadType(

diff --git a/lib/shared/thread-utils.js b/lib/shared/thread-utils.js
@@ -1798,7 +1798,7 @@ function createThreadTimestamps(
   };
 }
 
-function userSupportsThickThreads(
+function userHasDeviceList(
   userID: string,
   auxUserInfos: AuxUserInfos,
 ): boolean {
@@ -1874,5 +1874,5 @@ export {
   extractMentionedMembers,
   isMemberActive,
   createThreadTimestamps,
-  userSupportsThickThreads,
+  userHasDeviceList,
 };