-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lib] Move
selectFromGalleryAndUpdateThreadAvatar
from provider to …
…`avatar-hooks` Summary: This diff involved moving `selectFromGalleryAndUpdateThreadAvatar` from `EditThreadAvatarProvider` to `avatar-hooks.react.js`. 1. This allows us to better decouple the avatar providers and hooks. The providers are an entity(user/thread)-specific, but platform-agnostic interface b/w client and `keyserver`, whereas avatar hooks are platform-specific implementations. The coupling between providers and hooks made things difficult to work w/ when dealing w/ implementing image avatars on `web`. 2. Previously we had hooks which were "functions" of provider state which itself was a "function" of hooks. This diff starts to enforce the idea that hooks are "downstream" of providers.. which makes things easier to reason about. 3. `selectFromGallery` functionality is specific to `native` where we launch the image gallery programmatically and process the media selection. On `web`, we "virtually" click on the `<input>` to launch file selection, and then handle selected media from `onChange` callback... so things aren't as "sequential." NOTE: This is the "thread avatar version" of D8318. Test Plan: Still able to select and set image thread avatars on `native`. Reviewers: ashoat, ginsu Reviewed By: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D8736
- Loading branch information
1 parent
cf12040
commit 4b38dc2
Showing
4 changed files
with
35 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters