Skip to content

Commit

Permalink
[lib] Update id constants
Browse files Browse the repository at this point in the history
Summary:
[ENG-4595](https://linear.app/comm/issue/ENG-4595)
Not all ids were converted

Test Plan:
- for `bots.js` -> added a `console.log` in keyserver and web code and checked that only web had a prefix
- for `comm-staff-community` (I replaced `311733` with id of one of communities on my dev env for testing)
  - checked `id: '311733',` sent an image on web, confirmed that there is no "encryptionKey" in `extra` column in uploads
  - checked `id: process.env['KEYSERVER'] ? '311733' : '256|311733',` sent an image on web, confirmed that there is "encryptionKey"
- Searched for `id: '`, `id = '`, `'1`, `'2` etc. (case insensitive) and checked if there are any other constants
- Checked files in `facts/` for any id constants

Reviewers: tomek, bartek

Reviewed By: tomek, bartek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D8745
  • Loading branch information
MichalGniadek committed Aug 7, 2023
1 parent c054a1e commit 72a3200
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/facts/bots.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ type Bots = {
const bots: Bots = {
commbot: {
userID: '5',
staffThreadID: '83794',
staffThreadID: process.env['KEYSERVER'] ? '83794' : '256|83794',
},
};

Expand Down
2 changes: 1 addition & 1 deletion lib/facts/comm-staff-community.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ type CommStaffCommunity = {
};

const commStaffCommunity: CommStaffCommunity = {
id: '311733',
id: process.env['KEYSERVER'] ? '311733' : '256|311733',
};

export default commStaffCommunity;

0 comments on commit 72a3200

Please sign in to comment.