-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lib] Run conversion only on state check
Summary: [ENG-4524](https://linear.app/comm/issue/ENG-4524/performance-downgrade-on-the-web-app) The id schema conversion for the state check was run everytime selector needed to be rerun, even when it wasn't necessary (e.g. navigating between threads). This diff changes it to so that the conversion is run only when the state check is requested from the keyserver. Test Plan: - Checked that the state check still runs correctly - Can't reproduce the performance problem on my machine (too small redux) but checked the performance graph in the browser when navigating between threads: Before the changes: {F661658} After the changes: {F661638} You can see that the conversion doesn't run. For comparison here's the graph for the current master: {F661688} The highlighted `Cn` function is the id schema conversion function Reviewers: kamil, tomek, ashoat Reviewed By: kamil, ashoat Subscribers: ashoat Differential Revision: https://phab.comm.dev/D8649
- Loading branch information
1 parent
fa412e6
commit 9158eb6
Showing
1 changed file
with
30 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters