[rust] Fix Clippy warnings

Summary:
Fixed all remaining Clippy warnings for the workspace

Depends on D12178

Test Plan: No more Clippy warnings when running `cargo check` or `cargo clippy`

Reviewers: varun

Reviewed By: varun

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D12179

keyserver/addons/rust-node-addon/src/identity_client/login.rs

@@ -9,6 +9,7 @@ use tracing::debug;
 
 #[napi]
 #[instrument(skip_all)]
+#[allow(clippy::too_many_arguments)]
 pub async fn login_user(
   username: String,
   password: String,

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

@@ -212,6 +212,7 @@ mod tests {
   use super::CODE_VERSION;
 
   #[test]
+  #[allow(clippy::assertions_on_constants)]
   fn test_code_version_exists() {
     assert!(CODE_VERSION > 0);
   }

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

@@ -4,6 +4,7 @@ use tracing::{debug, warn};
 
 #[napi]
 #[instrument(skip_all)]
+#[allow(clippy::too_many_arguments)]
 pub async fn register_user(
   username: String,
   password: String,

native/native_rust_library/src/backup.rs

@@ -296,10 +296,10 @@ pub async fn create_userkeys_compaction(
 }
 
 pub async fn create_siwe_backup_msg_compaction(
-  backup_id: &String,
+  backup_id: &str,
   siwe_backup_msg: String,
 ) -> Result<(), Box<dyn Error>> {
-  let siwe_backup_msg_file = get_siwe_backup_message_path(&backup_id)?;
+  let siwe_backup_msg_file = get_siwe_backup_message_path(backup_id)?;
   tokio::fs::write(siwe_backup_msg_file, siwe_backup_msg).await?;
 
   Ok(())

native/native_rust_library/src/identity/login.rs

@@ -13,6 +13,7 @@ use super::{IdentityAuthResult, LogInPasswordUserInfo, LogInWalletUserInfo};
 use crate::utils::jsi_callbacks::handle_string_result_as_callback;
 use crate::{Error, CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME};
 
+#[allow(clippy::too_many_arguments)]
 pub mod ffi {
   use crate::identity::{
     DeviceKeys, LogInPasswordUserInfo, LogInWalletUserInfo,

native/native_rust_library/src/identity/registration.rs

@@ -19,6 +19,7 @@ use super::{
   RegisterReservedWalletUserInfo, RegisterWalletUserInfo,
 };
 
+#[allow(clippy::too_many_arguments)]
 pub mod ffi {
   use crate::identity::{
     DeviceKeys, RegisterPasswordUserInfo, RegisterReservedPasswordUserInfo,

native/native_rust_library/src/identity/x3dh.rs

@@ -86,6 +86,7 @@ pub mod ffi {
     });
   }
 
+  #[allow(clippy::too_many_arguments)]
   pub fn refresh_user_prekeys(
     auth_user_id: String,
     auth_device_id: String,

native/native_rust_library/src/lib.rs

@@ -41,6 +41,7 @@ use backup::ffi::*;
 use identity::ffi::*;
 use utils::future_manager::ffi::*;
 
+#[allow(clippy::too_many_arguments)]
 #[cxx::bridge]
 mod ffi {
 

services/blob/src/service.rs

@@ -168,7 +168,7 @@ impl BlobService {
     if let Some(invite_secret) =
       blob_hash.strip_prefix(INVITE_LINK_BLOB_HASH_PREFIX)
     {
-      Self::validate_invite_link_blob_hash(&invite_secret)?;
+      Self::validate_invite_link_blob_hash(invite_secret)?;
     }
 
     let mut upload_session =

services/commtest/src/identity/mod.rs

@@ -37,7 +37,7 @@ impl SigningCapableAccount {
   }
 
   /// signs message, returns signature
-  pub fn sign_message(&mut self, message: &str) -> String {
+  pub fn sign_message(&self, message: &str) -> String {
     let signature: Signature = self.signing_key.sign(message.as_bytes());
     base64::engine::general_purpose::STANDARD_NO_PAD
       .encode(signature.to_bytes())

services/commtest/tests/identity_access_tokens_tests.rs

@@ -43,7 +43,7 @@ async fn refresh_token_test() {
   .await
   .expect("Couldn't connect to identity service");
 
-  let mut account = SigningCapableAccount::new();
+  let account = SigningCapableAccount::new();
   let client_keys = account.public_keys();
   let user = register_user_device(Some(&client_keys), None).await;
 

services/commtest/tests/identity_one_time_key_tests.rs

@@ -81,8 +81,8 @@ async fn max_hundred_keys_in_ddb() {
       (0..20).map(|_| generate_random_olm_key()).collect();
 
     if request_num == 0 {
-      expected_first_retrieved_content_key = content_keys.get(0).cloned();
-      expected_first_retrieved_notif_key = notif_keys.get(0).cloned();
+      expected_first_retrieved_content_key = content_keys.first().cloned();
+      expected_first_retrieved_notif_key = notif_keys.first().cloned();
       expected_second_retrieved_content_key = content_keys.get(5).cloned();
       expected_second_retrieved_notif_key = notif_keys.get(5).cloned();
     }

services/identity/src/database.rs

@@ -207,6 +207,7 @@ impl DatabaseClient {
     Ok(user_id)
   }
 
+  #[allow(clippy::too_many_arguments)]
   pub async fn add_wallet_user_to_users_table(
     &self,
     flattened_device_key_upload: FlattenedDeviceKeyUpload,

services/identity/src/grpc_services/authenticated.rs

@@ -677,6 +677,7 @@ impl IdentityClientService for AuthenticatedService {
   }
 }
 
+#[allow(dead_code)]
 enum DeviceListItemKind {
   Any,
   Primary,

services/identity/src/grpc_services/shared.rs

@@ -1,6 +1,6 @@
 use grpc_clients::error::unsupported_version;
-use tonic::{IntoRequest, Request, Status};
-use tracing::{trace, Instrument};
+use tonic::{Request, Status};
+use tracing::trace;
 
 use crate::constants::{request_metadata, MIN_SUPPORTED_NATIVE_VERSION};
 

services/identity/src/regex.rs

@@ -29,11 +29,13 @@ mod tests {
     ));
   }
 
+  #[allow(clippy::bool_assert_comparison)]
   #[test]
   fn test_invalid_username_too_short() {
     assert_eq!(is_valid_username(""), false);
   }
 
+  #[allow(clippy::bool_assert_comparison)]
   #[test]
   fn test_invalid_username_too_long() {
     assert_eq!(
@@ -42,11 +44,13 @@ mod tests {
     );
   }
 
+  #[allow(clippy::bool_assert_comparison)]
   #[test]
   fn test_invalid_username_first_char_non_alphanumeric() {
     assert_eq!(is_valid_username("-asdf"), false);
   }
 
+  #[allow(clippy::bool_assert_comparison)]
   #[test]
   fn test_invalid_username_invalid_symbol() {
     assert_eq!(is_valid_username("asdf$"), false);

services/identity/src/siwe.rs

@@ -121,6 +121,7 @@ mod tests {
     ));
   }
 
+  #[allow(clippy::bool_assert_comparison)]
   #[test]
   fn test_invalid_ethereum_address() {
     // Shorter than 42 characters

shared/comm-lib/src/lib.rs

@@ -11,6 +11,7 @@ pub mod http;
 pub mod shared;
 pub mod tools;
 
+#[allow(unused_imports)]
 mod reexports {
   #[cfg(feature = "blob-client")]
   pub use {bytes, reqwest};
@@ -30,4 +31,6 @@ mod reexports {
     pub use ddb::Error as DynamoDBError;
   }
 }
+
+#[allow(unused_imports)]
 pub use reexports::*;