[keyserver, web] Remove baseHref field

Summary:
issue: https://linear.app/comm/issue/ENG-4214/review-basehref-filed-in-web-redux
`baseHref` field can be merged with `urlPrefix`. To see the full explanation see the discussion in the linked issue.

Test Plan: Checked that web still works - connects to the keyserver. Ran `yarn flow-all`

Reviewers: michal, kamil

Reviewed By: michal

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8704

keyserver/src/responders/website-responders.js

@@ -196,12 +196,11 @@ const initialReduxStateValidator = tShape({
     'default communityPickerStore',
     _isEqual({ chat: null, calendar: null }),
   ),
-  urlPrefix: tString(''),
+  urlPrefix: t.String,
   windowDimensions: t.irreducible(
     'default windowDimensions',
     _isEqual({ width: 0, height: 0 }),
   ),
-  baseHref: t.String,
   notifPermissionAlertInfo: t.irreducible(
     'default notifPermissionAlertInfo',
     _isEqual(defaultNotifPermissionAlertInfo),
@@ -267,7 +266,7 @@ async function websiteResponder(
   const appURLFacts = getAppURLFactsFromRequestURL(req.originalUrl);
   const { basePath, baseDomain } = appURLFacts;
   const baseURL = basePath.replace(/\/$/, '');
-  const baseHref = baseDomain + baseURL;
+  const urlPrefix = baseDomain + baseURL;
 
   const loadingPromise = getWebpackCompiledRootComponentForSSR();
   const hasNotAcknowledgedPoliciesPromise = hasAnyNotAcknowledgedPolicies(
@@ -581,10 +580,8 @@ async function websiteResponder(
     loadingStatuses: {},
     calendarFilters: defaultCalendarFilters,
     communityPickerStore: { chat: null, calendar: null },
-    // We can use paths local to the <base href> on web
-    urlPrefix: '',
+    urlPrefix,
     windowDimensions: { width: 0, height: 0 },
-    baseHref,
     notifPermissionAlertInfo: defaultNotifPermissionAlertInfo,
     connection: (async () => ({
       ...defaultConnectionInfo(viewer.platform ?? 'web', viewer.timeZone),

web/redux/redux-setup.js

@@ -83,7 +83,6 @@ export type AppState = {
   +urlPrefix: string,
   +windowDimensions: WindowDimensions,
   +deviceToken: ?string,
-  +baseHref: string,
   +notifPermissionAlertInfo: NotifPermissionAlertInfo,
   +connection: ConnectionInfo,
   +watchedThreadIDs: $ReadOnlyArray<string>,

web/selectors/socket-selectors.js

@@ -29,7 +29,7 @@ import { initOlm } from '../olm/olm-utils.js';
 import type { AppState } from '../redux/redux-setup.js';
 
 const openSocketSelector: (state: AppState) => () => WebSocket = createSelector(
-  (state: AppState) => state.baseHref,
+  (state: AppState) => state.urlPrefix,
   createOpenSocketFunction,
 );