Skip to content

Commit

Permalink
[lib] Fix comment in kesyerver-types
Browse files Browse the repository at this point in the history
Summary:
I noticed that the comment was incorrect. In the future, the cookie type will be one of `string | undefined | null`, but the field will have to be specified.
So the field declaration will need to be `+cookie: ?string,`.

Test Plan: N/A

Reviewers: michal, kamil

Reviewed By: michal

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8812
  • Loading branch information
InkaAlicja committed Aug 16, 2023
1 parent 41605dc commit f072f60
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/types/keyserver-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import t, { type TInterface } from 'tcomb';
import { tShape } from '../utils/validation-utils.js';

// Once we start using the cookie field on web,
// the cookie field type should be changed to string | null.
// the cookie field should be mandatory, of type ?string.
// See https://linear.app/comm/issue/ENG-4347/stop-using-browser-cookies
export type KeyserverInfo = {
+cookie?: ?string,
Expand Down

0 comments on commit f072f60

Please sign in to comment.