[lib] Rename updateImageUserAvatar to baseUpdateImageUserAvatar i…

…n `EditUserAvatarProvider`

Summary:
Effectively the same as D8344, but for `updateImageUserAvatar`.

We want devs to use the platform-specific `updateImageUserAvatar` wrappers rather than interfacing with `updateImageUserAvatar` directly... so renaming with `base` prefix to make that more clear.

Also left a comment.

---

Depends on D8348

Test Plan: flow/eslint/searched codebase for "updateImageUserAvatar".

Reviewers: ashoat, ginsu, rohan

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D8360

lib/components/edit-user-avatar-provider.react.js

@@ -34,7 +34,7 @@ const registrationModeOff = { registrationMode: 'off' };
 export type EditUserAvatarContextType = {
   +setUserAvatarMediaUploadInProgress: SetState<boolean>,
   +userAvatarSaveInProgress: boolean,
-  +updateImageUserAvatar: (
+  +baseUpdateImageUserAvatar: (
     imageAvatarUpdateRequest: ImageAvatarDBContent,
   ) => Promise<void>,
   +baseSetUserAvatar: (avatarRequest: UpdateUserAvatarRequest) => Promise<void>,
@@ -73,7 +73,9 @@ function EditUserAvatarProvider(props: Props): React.Node {
     userAvatarMediaUploadInProgress ||
     updateUserAvatarLoadingStatus === 'loading';
 
-  const updateImageUserAvatar = React.useCallback(
+  // NOTE: Do **NOT** consume `baseUpdateImageUserAvatar` directly.
+  //       Use platform-specific `[web/native]UpdateImageUserAvatar` instead.
+  const baseUpdateImageUserAvatar = React.useCallback(
     async (imageAvatarUpdateRequest: ImageAvatarDBContent) => {
       const promise = (async () => {
         setUserAvatarMediaUploadInProgress(false);
@@ -85,7 +87,7 @@ function EditUserAvatarProvider(props: Props): React.Node {
     [dispatchActionPromise, updateUserAvatarCall],
   );
 
-  // NOTE: Do NOT consume `baseSetUserAvatar` directly.
+  // NOTE: Do **NOT** consume `baseSetUserAvatar` directly.
   //       Use platform-specific `[web/native]SetUserAvatar` instead.
   const baseSetUserAvatar = React.useCallback(
     async (request: UpdateUserAvatarRequest) => {
@@ -115,7 +117,7 @@ function EditUserAvatarProvider(props: Props): React.Node {
     () => ({
       setUserAvatarMediaUploadInProgress,
       userAvatarSaveInProgress,
-      updateImageUserAvatar,
+      baseUpdateImageUserAvatar,
       baseSetUserAvatar,
       setRegistrationMode,
       getRegistrationModeEnabled,
@@ -124,7 +126,7 @@ function EditUserAvatarProvider(props: Props): React.Node {
     [
       setUserAvatarMediaUploadInProgress,
       userAvatarSaveInProgress,
-      updateImageUserAvatar,
+      baseUpdateImageUserAvatar,
       baseSetUserAvatar,
       setRegistrationMode,
       getRegistrationModeEnabled,

native/avatars/avatar-hooks.js

@@ -244,7 +244,7 @@ function useNativeUpdateUserImageAvatar(): (
   const editUserAvatarContext = React.useContext(EditUserAvatarContext);
   invariant(editUserAvatarContext, 'editUserAvatarContext must be defined');
   const {
-    updateImageUserAvatar,
+    baseUpdateImageUserAvatar,
     getRegistrationModeEnabled,
     getRegistrationModeSuccessCallback,
     setUserAvatarMediaUploadInProgress,
@@ -276,15 +276,15 @@ function useNativeUpdateUserImageAvatar(): (
       }
 
       try {
-        await updateImageUserAvatar(imageAvatarUpdateRequest);
+        await baseUpdateImageUserAvatar(imageAvatarUpdateRequest);
       } catch {
         displayAvatarUpdateFailureAlert();
       }
     },
     [
       getRegistrationModeEnabled,
       getRegistrationModeSuccessCallback,
-      updateImageUserAvatar,
+      baseUpdateImageUserAvatar,
       uploadSelectedMedia,
     ],
   );