implement group-edit #157
Merged
implement group-edit #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmodi
force-pushed
the
group-edit
branch
2 times, most recently
from
dd6a617
to
1cf06e0
Compare
hjmodi
force-pushed
the
group-edit
branch
3 times, most recently
from
ae3b157
to
dc8fec3
Compare
ligangty
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Did some test and found issues:
- When create new group, the available is not shown.
- When edit the group, after adding/removing the constituents and click save to send the requests, the group json sent is not correct for the constituents part. (The added/removed constituents are not saved in sent group json)
Signed-off-by: Harsh Modi <[email protected]>
Signed-off-by: Harsh Modi <[email protected]>
It was being overwritten by old changelog from data.metadata.changelog Signed-off-by: Harsh Modi <[email protected]>
Signed-off-by: Harsh Modi <[email protected]>
Signed-off-by: Harsh Modi <[email protected]>
Signed-off-by: Harsh Modi <[email protected]>
both are fixed now. PTAL |
ligangty
reviewed
Feb 2, 2024
ligangty
reviewed
Feb 2, 2024
Remove the package itself from available list Remove duplicates if there are any Remove all other packages of not the same type Signed-off-by: Harsh Modi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.