Add GD32F10x SPL files from GD32F10x_Firmware_Library_V2.2.4 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember there were some ever-standing bugs in the verbatim SPL, like them defining their own BOOL / FALSE / TRUE type or a bug in the SPI frequency setting code not clearing the previous value. Will have to look at it carefully. |
|
Yep, I have those changes in my messy branch. I just wanted to get the verbatim files in there so the changes I make to get it working are more obvious. |
|
To be clear I won't be adding any changes to this pull request... I intend break up my monolith draft PR into smaller more readable chunks to facilitate discussion, and not litter with thousands of lines of added 3rd party code. |
|
Just kidding, I couldn't find my source for the rar file, so I grabbed the latest from GigaDevices. |
dmlambo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for further F103 changes. No changes made to the files yet, these are directly from GD32F10x_Firmware_Library_V2.2.3.rar