Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better line numbers for markdown source generator diagnostics #92

Open
michael-hawker opened this issue May 3, 2022 · 0 comments
Open
Labels
enhancement Improvement to an existing feature good first issue Good for newcomers source generator ⚙️
Milestone

Comments

@michael-hawker
Copy link
Member

michael-hawker commented May 3, 2022

There are a few TODO items in the ToolkitSampleMetadataGenerator.*.cs files related to line numbers for diagnostics for some of the frontmatter/sample references.

This issue is to track fixing those to provide better line numbers pointing to where the error is coming from.

We'll have to re-perform a search/match I think to get the line location in the original file (if we have the text there).

Originally posted by @Arlodotexe in #85 (comment)

There's also an open question see here about whether or not we should emit a warning if there's no documentation provided (in an experiment)?

@michael-hawker michael-hawker added enhancement Improvement to an existing feature good first issue Good for newcomers source generator ⚙️ labels May 3, 2022
@michael-hawker michael-hawker added this to the Future milestone May 3, 2022
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this issue Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature good first issue Good for newcomers source generator ⚙️
Projects
None yet
Development

No branches or pull requests

1 participant