-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests as part of CI #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they ran great on the last past. Do we know how test results are bubbled up in GitHub actions? (Like if they fail I assume the build will fail, but if we want to search/look up the output for an individual test, can we do that easily somehow?)
I'll push an update with a failing test so it can be seen. |
So, good news, a failing test does fail the CI checks. The details of why it failed aren't always going to be super obvious. (We don't even get coloring.) Removing the failed test now. |
This reverts commit effde14.
@mrlacey looks like we may need another action to push/bubble results. This one looked interesting: https://github.com/marketplace/actions/test-reporter, though there's an updated clone here in the marketplace that I'm looking to get info on: https://github.com/phoenix-actions/test-reporting Once the repo is public, I think we could maybe just try this one as well: https://github.com/marketplace/testspace-com/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW41OTc0#pricing-and-setup |
What's the desired output? |
The CI test reports are currently created with https://github.com/dorny/test-reporter It's also using a format that's supported by https://github.com/marketplace/testspace-com so switching to that should be painless if we eventually want to move to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrate running unit tests as part of the PR CI
For #48