Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NuGet package included source code #81 #83

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

Arlodotexe
Copy link
Member

Fixed an issue where source code was included in the nuget package. Closes #81

Before:
image

After:
image

@michael-hawker
Copy link
Member

Sweet! Assume this is the same for both the UWP/WinUI packages?

Does this change anything with #37 or is that still an issue (does the new Uno 4.2 make a change there)?

@Arlodotexe
Copy link
Member Author

Does this change anything with #37 or is that still an issue (does the new Uno 4.2 make a change there)?

This only affects the generated nuget packages, doesn't change anything with the content bundled into the app. We'll have to check separately what would happen if we update to 4.2.

@michael-hawker michael-hawker merged commit c7db198 into main Apr 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/source-in-nuget-package branch April 27, 2022 07:00
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet package includes source code
2 participants