Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong version for Nightly builds #909

Closed
2 tasks done
twsl opened this issue Jan 19, 2023 · 4 comments
Closed
2 tasks done

[BUG] Wrong version for Nightly builds #909

twsl opened this issue Jan 19, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@twsl
Copy link

twsl commented Jan 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

  • I have read the "Reporting a bug" section on Contributing file.

Current Behavior

As shown in #852, the regular release on nuget is tagged with version 3.1.0, the nightly builds are tagged as 1.0.0-preview. Which means it always shows the regular build as latest version and causes issues with other libraries that require CommunityToolkit >= 3.0.0

Expected Behavior

Tag nightly library accordingly

Steps To Reproduce

  1. Add nuget feed
  2. try to update

Link to public reproduction project repository

https://github.com/twsl/Maui/tree/feature/version

Environment

- .NET MAUI CommunityToolkit:3.1.0
- OS: Windows 11
- .NET MAUI: 7

Anything else?

No response

@twsl twsl added bug Something isn't working unverified labels Jan 19, 2023
@twsl
Copy link
Author

twsl commented Jan 19, 2023

A simple fix has been proposed because azure pipelines offer no way for me to test the code locally

@vhugogarcia
Copy link
Contributor

@brminnick I believe this can maybe be moved to a discussion about the versioning strategy first, and so everybody can share ideas for nightly builds, etc. I noticed the PR was closed and not anymore movement there.

So, I think we can also close this issue.

Regards,
Victor

@VladislavAntonyuk
Copy link
Collaborator

@vhugogarcia we had an open PR. For nightly builds for simplicity we decided to use version 99 to ensure it is higher than our regular version

@bijington
Copy link
Contributor

I did also have a branch working with GitVersion but we didn't work out the tagging approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants