-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Base Version in azure-pipelines.yml #910
Conversation
Is there a way to automatically set its version number based on the version number of the latest release? Otherwise, we will have the same problem after we release v4.0.0. |
https://git-scm.com/docs/git-describe Sadly I don't know how we would determine the type of change and ultimately the change in version component. The best long term solution is to use a tool like GitVersion that just does it for us |
I think we can set the version number to 99.99.99.99, in that case it will always be a latest version, if user wants to use nightly builds |
Works for me! |
as proposed in the discussion, ideally something like GitVersion would be used to automatically calculate the semver. Just using the same version number for everything might cause other problems in the future but could work for now |
as our next release is 4.0.0, let's for now use 4.1.0 and see how it works. |
Can someone else approve this so it gets merged? |
@brminnick, @jfversluis are you ok with the changes? |
If this is not urgent, I prefer that we implement a permanent solution that references the latest release number and works for both This is a pretty low-effort PR that doesn't actually fix anything; it just delays the problem and creates more work for us in the future (we'll have to open a PR to bump this version number after every release). |
@twsl Could you please investigate how we can use GitVersion solution? |
I can try, the issue with that is that I cannot test the azure pipelines locally |
@twsl don't worry about it. If the build passes, you can find the version number in the GitHub actions result: |
@twsl are you happy looking into the GitVersion approach? If not then I would be happy to help out |
@bijington Feel free to tackle this. I did a quick test and just adding the nuget to the project causes issues and fails to build. Not sure if this requires GitTools/GitVersion#3334. Adding the azure pipelines task could also be a solution tho |
Thanks for having a look. I'll look into that issue and hope that we can workaround it |
@dotnet-policy-service agree |
@jfversluis this reminds me we need to have a chat about GitVersion |
Description of Change
This is a quick and dirty fix for the issue regarding the nightly versions by raising the semantic base version.
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information