-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow change position after MediaEnded event #1315
Allow change position after MediaEnded event #1315
Conversation
@dotnet-policy-service agree |
1 similar comment
@dotnet-policy-service agree |
https://github.com/niksedk/Maui into feature/Allow-change-position-after-media-ended-event
I'm pretty sure we have a good reason to keep the timer. So removing it doesn't look like the right solution |
This PR is not removing the timer... it's keeping it active :) The timer is started in |
And we never stop the timer? |
Ah, good point. OK, the |
https://github.com/niksedk/Maui into feature/Allow-change-position-after-media-ended-event
@jfversluis can you take a look at this PR and make sure that it's fine to change the behavior of the timer? I believe this will be a breaking change anyway. |
Description of Change
Allow change position after MediaEnded event
The report-status-timer in this PR is:
OnMediaOpened
(when a new media opened successfully)OnSourcePropertyChanged
(when opening a new media or setting media to null)This will keep the status/positioning/progress-bar alive until the media is set to null or a new media is loaded, but dragging the progress-bar-position to the end, will not stop the status/positioning/progress-bar from being alive.
Linked Issues