Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix popup margin on iOS #1329

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Fix popup margin on iOS #1329

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca28ee8
Fix popup margin on iOS
cat0363 Aug 10, 2023
f03be0c
Merge branch 'main' into Issue-1328
cat0363 Aug 10, 2023
dbb3051
Merge branch 'main' into Issue-1328
brminnick Aug 10, 2023
4b7c481
Merge branch 'main' into Issue-1328
brminnick Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/CommunityToolkit.Maui.Core/Views/Popup/PopupExtensions.macios.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ public static void SetLayout(this MauiPopup mauiPopup, in IPopup popup)

mauiPopup.PopoverPresentationController.SourceRect = new CGRect(originX, originY, 0, 0);
mauiPopup.PopoverPresentationController.PermittedArrowDirections = 0;
// From the point of view of usability, the top, bottom, left, and right values of UIEdgeInsets cannot all be 0.
// If you specify 0 for the top, bottom, left, and right of UIEdgeInsets, the default margins will be added, so
// specify a value as close to 0 here as possible.
mauiPopup.PopoverPresentationController.PopoverLayoutMargins = new UIEdgeInsets(0.0001f, 0.0001f, 0.0001f, 0.0001f);
}
else
{
Expand Down