-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Snackbar rewrite #1658
Merged
Merged
Windows Snackbar rewrite #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces ToastNotification with AppNotificationManager. Fixes Snackbar and Toast execute new instance of the app
pictos
reviewed
Jan 24, 2024
samples/CommunityToolkit.Maui.Sample/Platforms/Windows/Package.appxmanifest
Outdated
Show resolved
Hide resolved
VladislavAntonyuk
added
the
needs discussion
Discuss it on the next Monthly standup
label
Jan 30, 2024
pictos
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
VladislavAntonyuk
removed
the
needs discussion
Discuss it on the next Monthly standup
label
Feb 19, 2024
Merged
brminnick
added
breaking change
This label is used for PRs that include a breaking change
and removed
pending documentation
This feature requires documentation
labels
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces ToastNotification with AppNotificationManager. Fixes Snackbar and Toast execute new instance of the app
Description of Change
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information