Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Snackbar rewrite #1658

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Windows Snackbar rewrite #1658

merged 8 commits into from
Feb 19, 2024

Conversation

VladislavAntonyuk
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk commented Jan 24, 2024

Replaces ToastNotification with AppNotificationManager. Fixes Snackbar and Toast execute new instance of the app

Description of Change

Linked Issues

PR Checklist

Additional information

Replaces ToastNotification with AppNotificationManager. Fixes Snackbar and Toast execute new instance of the app
@VladislavAntonyuk VladislavAntonyuk requested a review from a team January 24, 2024 20:18
@VladislavAntonyuk VladislavAntonyuk self-assigned this Jan 24, 2024
@VladislavAntonyuk VladislavAntonyuk added the needs discussion Discuss it on the next Monthly standup label Jan 30, 2024
@VladislavAntonyuk VladislavAntonyuk requested a review from a team February 2, 2024 10:14
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pictos pictos added the pending documentation This feature requires documentation label Feb 15, 2024
@VladislavAntonyuk VladislavAntonyuk removed the needs discussion Discuss it on the next Monthly standup label Feb 19, 2024
@VladislavAntonyuk VladislavAntonyuk enabled auto-merge (squash) February 19, 2024 16:35
@VladislavAntonyuk VladislavAntonyuk merged commit 3cda1bd into main Feb 19, 2024
8 checks passed
@VladislavAntonyuk VladislavAntonyuk deleted the feature/snakbar-rewrite branch February 19, 2024 16:35
@brminnick brminnick mentioned this pull request Mar 28, 2024
@brminnick brminnick added breaking change This label is used for PRs that include a breaking change and removed pending documentation This feature requires documentation labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This label is used for PRs that include a breaking change
Projects
None yet
4 participants