-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting Triggers #13
Porting Triggers #13
Conversation
Fixed XAML Styling, hopefully will see build info now |
Seeing issues with DispatcherQueue extension?
Does this just depend on #12 now too? |
Hopefully the last remaining issues:
Wonder if we want the Leads into the CommunityToolkit/Tooling-Windows-Submodule#33 discussion on what we should do with Uno0001 errors as well and either not raise them as errors (except locally on the WASM head) maybe? Let them flow through so we can identify things folks want to use and point to Uno issues later vs. having to ensure everything works or code it out (as if code it out and Uno releases a build which it works for, then it's still not usable vs. the other way around). @Arlodotexe I think this just means we need to set Uno0001 as |
Ugh meant to rebase... anyway, @niels9001 the NoWarn was added to main so this should hopefully just build now? |
Couple of warnings as errors:
|
@niels9001 think we're good, just want to rename the test file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the go around, did a final pass and noticed an extra indentation to a file, and realized we could tidy up another small thing.
Current triggers are not fully supported:
FullScreenModeStateTrigger: Uno / WASDK
UserInteractionMode: Uno / WASDK