Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double-slashes from Project Paths #165

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Aug 4, 2023

Helps with UWP project heads and old-project system now for some reason after single-experiment heads broke with #152 #164

There's still an issue with some projects (like Behaviors) that reference other projects within their source projects (like Animations).

The UWP single-component head isn't picking up that transitive dependency and failing to build. If you manually add the Animations reference to the UWP app head, then it starts working again... Assuming this is some issue with the old-style project, as the WASDK head works fine (before and after this change).

We'll either have to follow-up with the tooling team and/or find a workaround for this in our props files...

Helps with UWP project heads and old-project system now for some reason
after single-experiment heads broke with #152 #164
@michael-hawker
Copy link
Member Author

Not sure if we'll hit an msbuild issue again in the CI, as we originally had tried to do this when porting Behaviors back here: #20 (comment)

@michael-hawker
Copy link
Member Author

Ugh, same issue as before in previous port of Behaviors project:

2023-08-04T23:24:31.8485112Z        "D:\a\Windows\Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
2023-08-04T23:24:31.8485695Z        "D:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Tests.WinAppSdk\CommunityToolkit.Tests.WinAppSdk.csproj" (default target) (51:6) ->
2023-08-04T23:24:31.8486448Z        "D:\a\Windows\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj" (GetTargetPathWithTargetPlatformMoniker target) (15:714) ->
2023-08-04T23:24:31.8487200Z          D:\a\Windows\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj : error MSB4057: The target "GetTargetPathWithTargetPlatformMoniker" does not exist in the project.
2023-08-04T23:24:31.8487584Z 
2023-08-04T23:24:31.8487590Z 
2023-08-04T23:24:31.8487838Z        "D:\a\Windows\Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
2023-08-04T23:24:31.8488426Z        "D:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Tests.WinAppSdk\CommunityToolkit.Tests.WinAppSdk.csproj" (default target) (51:6) ->
2023-08-04T23:24:31.8489143Z        "D:\a\Windows\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj" (GetTargetPathWithTargetPlatformMoniker target) (15:715) ->
2023-08-04T23:24:31.8489859Z          D:\a\Windows\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj : error MSB4057: The target "GetTargetPathWithTargetPlatformMoniker" does not exist in the project.
2023-08-04T23:24:31.8490873Z 
2023-08-04T23:24:31.8491219Z     29 Warning(s)
2023-08-04T23:24:31.8493137Z     2 Error(s)

So, we've come around full circle, except this time the double-slashes cause more problems for the Behaviors project...

Not sure if these threads have any info we can use: dotnet/msbuild#8985, dotnet/msbuild#2298, or dotnet/msbuild#4303

@michael-hawker
Copy link
Member Author

Update tooling submodule to main now that tooling pr in.

@michael-hawker michael-hawker marked this pull request as ready for review August 8, 2023 23:16
@michael-hawker michael-hawker enabled auto-merge (squash) August 8, 2023 23:17
@michael-hawker michael-hawker merged commit 4194901 into main Aug 8, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the llama/fix-slashes branch August 8, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants