Upgrade to .NET 7, enable WASM optimizations #173

Arlodotexe · 2023-08-11T19:55:29Z

Companion PR to CommunityToolkit/Tooling-Windows-Submodule#117, which should be closed before merging this.

As noted:

Any codebase consuming the tooling repo will need to be adjusted to account for the new nullable annotations and analyzers added between netstandard2.0 and net7.0.

This PR pulls in the .NET 7 upgrade and fixes the new warnings and errors that appeared in our codebase as a result.

Arlodotexe · 2023-08-11T20:13:44Z

Local packages were built for this branch tested to work on these platforms:

Android

Runtime error, see details.

        > System.InvalidOperationException: 'Failed to load ToolkitPackageUwpUnoTest.MainPage: Java.Lang.ClassNotFoundException: crc643edf5f81ce7abab9.Segmented
        > ---> Java.Lang.ClassNotFoundException: Didn't find class "crc643edf5f81ce7abab9.Segmented" on path: DexPathList[[zip file "/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk"],nativeLibraryDirectories=[/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/lib/x86_64, /data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk!/lib/x86_64, /system/lib64, /system_ext/lib64]]
        > --- End of managed Java.Lang.ClassNotFoundException stack trace ---
        > java.lang.ClassNotFoundException: Didn't find class "crc643edf5f81ce7abab9.Segmented" on path: DexPathList[[zip file "/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk"],nativeLibraryDirectories=[/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/lib/x86_64, /data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk!/lib/x86_64, /system/lib64, /system_ext/lib64]]
        > 	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        > 	at java.lang.Class.classForName(Native Method)
        > 	at java.lang.Class.forName(Class.java:454)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.n_onActivityStarted(Native Method)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.onActivityStarted(NativeApplication_ActivityCallbacks.java:99)
        > 	at android.app.Application.dispatchActivityStarted(Application.java:401)
        > 	at android.app.Activity.dispatchActivityStarted(Activity.java:1409)
        > 	at android.app.Activity.onStart(Activity.java:1948)
        > 	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:496)
        > 	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:246)
        > 	at crc6467d88aaa7548788d.BaseActivity.n_onStart(Native Method)
        > 	at crc6467d88aaa7548788d.BaseActivity.onStart(BaseActivity.java:611)
        > 	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1543)
        > 	at android.app.Activity.performStart(Activity.java:8367)
        > 	at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3669)
        > 	at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:224)
        > 	at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:204)
        > 	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
        > 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
        > 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2306)
        > 	at android.os.Handler.dispatchMessage(Handler.java:106)
        > 	at android.os.Looper.loopOnce(Looper.java:201)
        > 	at android.os.Looper.loop(Looper.java:288)
        > 	at android.app.ActivityThread.main(ActivityThread.java:7918)
        > 	at java.lang.reflect.Method.invoke(Native Method)
        > 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        > 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
        > --- End of managed Java.Lang.ClassNotFoundException stack trace ---
        > java.lang.ClassNotFoundException: Didn't find class "crc643edf5f81ce7abab9.Segmented" on path: DexPathList[[zip file "/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk"],nativeLibraryDirectories=[/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/lib/x86_64, /data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk!/lib/x86_64, /system/lib64, /system_ext/lib64]]
        > 	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        > 	at java.lang.Class.classForName(Native Method)
        > 	at java.lang.Class.forName(Class.java:454)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.n_onActivityStarted(Native Method)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.onActivityStarted(NativeApplication_ActivityCallbacks.java:99)
        > 	at android.app.Application.dispatchActivityStarted(Application.java:401)
        > 	at android.app.Activity.dispatchActivityStarted(Activity.java:1409)
        > 	at android.app.Activity.onStart(Activity.java:1948)
        > 	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:496)
        > 	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:246)
        > 	at crc6467d88aaa7548788d.BaseActivity.n_onStart(Native Method)
        > 	at crc6467d88aaa7548788d.BaseActivity.onStart(BaseActivity.java:611)
        > 	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1543)
        > 	at android.app.Activity.performStart(Activity.java:8367)
        > 	at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3669)
        > 	at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:224)
        > 	at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:204)
        > 	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
        > 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
        > 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2306)
        > 	at android.os.Handler.dispatchMessage(Handler.java:106)
        > 	at android.os.Looper.loopOnce(Looper.java:201)
        > 	at android.os.Looper.loop(Looper.java:288)
        > 	at android.app.ActivityThread.main(ActivityThread.java:7918)
        > 	at java.lang.reflect.Method.invoke(Native Method)
        > 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        > 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
        > --- End of inner exception stack trace ---
        > at Java.Interop.JniEnvironment.StaticMethods.CallStaticObjectMethod(JniObjectReference type, JniMethodInfo method, JniArgumentValue* args) in /Users/runner/work/1/s/xamarin-android/external/Java.Interop/src/Java.Interop/obj/Release/net7.0/JniEnvironment.g.cs:line 12890
        > at Android.Runtime.JNIEnv.FindClass(String classname) in /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNIEnv.cs:line 577
        > at Android.Runtime.JNIEnv.FindClass(Type type) in /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNIEnv.cs:line 532
        > at Uno.UI.NativeInstanceHelper.CreateTypeReference(Type type) in C:\a\1\s\src\Uno.UI\Extensions\NativeViewInstanceHelper.Android.cs:line 121
        > at Uno.UI.NativeInstanceHelper.CreateNativeInstance(Type type, Object target, Context context, Action`2 setInstance) in C:\a\1\s\src\Uno.UI\Extensions\NativeViewInstanceHelper.Android.cs:line 97
        > at Uno.UI.Controls.BindableView..ctor(Context context) in C:\a\1\s\src\Uno.UI\Controls\BindableView.Android.cs:line 48
        > at Windows.UI.Xaml.UIElement..ctor() in C:\a\1\s\src\Uno.UI\UI\Xaml\UIElement.Android.cs:line 84
        > at Windows.UI.Xaml.FrameworkElement..ctor() in C:\a\1\s\src\Uno.UI\UI\Xaml\FrameworkElement.Android.cs:line 29
        > at Windows.UI.Xaml.Controls.Control..ctor() in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\Control\Control.Android.cs:line 9
        > at Windows.UI.Xaml.Controls.ItemsControl..ctor() in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\ItemsControl\ItemsControl.cs:line 83
        > at Windows.UI.Xaml.Controls.Primitives.Selector..ctor() in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\Primitives\Selector.cs:line 54
        > at Windows.UI.Xaml.Controls.ListViewBase..ctor() in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\ListViewBase\ListViewBase.cs:line 55
        > at CommunityToolkit.WinUI.Controls.Segmented..ctor() in /_/components/Segmented/src/Segmented/Segmented.cs:line 14
        > at ToolkitPackageUwpUnoTest.MainPage.InitializeComponent_C485E415() in D:\source\uwp\app_\ToolkitPackageUwpUnoTest\ToolkitPackageUwpUnoTest.Mobile\Uno.UI.SourceGenerators\Uno.UI.SourceGenerators.XamlGenerator.XamlCodeGenerator\MainPage_ba262bb41580a9a89dedc5da47a1ff49.cs:line 72
        > at ToolkitPackageUwpUnoTest.MainPage.InitializeComponent() in D:\source\uwp\app_\ToolkitPackageUwpUnoTest\ToolkitPackageUwpUnoTest.Mobile\Uno.UI.SourceGenerators\Uno.UI.SourceGenerators.XamlGenerator.XamlCodeGenerator\MainPage_ba262bb41580a9a89dedc5da47a1ff49.cs:line 58
        > at ToolkitPackageUwpUnoTest.MainPage..ctor() in D:\source\uwp\app_\ToolkitPackageUwpUnoTest\ToolkitPackageUwpUnoTest.Shared\MainPage.xaml.cs:line 27
        > at ToolkitPackageUwpUnoTest.Mobile.MetadataBuilder_757.CreateInstance() in D:\source\uwp\app_\ToolkitPackageUwpUnoTest\ToolkitPackageUwpUnoTest.Mobile\Uno.UI.SourceGenerators\Uno.UI.SourceGenerators.BindableTypeProviders.BindableTypeProvidersSourceGenerator\BindableMetadata.g.cs:line 30743
        > at Windows.UI.Xaml.Controls.Frame.CreatePageInstance(Type sourcePageType) in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\Frame\Frame.cs:line 454
        > at Windows.UI.Xaml.PagePool.DequeuePage(Type pageType) in C:\a\1\s\src\Uno.UI\UI\Xaml\PagePool.cs:line 69
        > at Windows.UI.Xaml.Controls.Frame.CreatePageInstanceCached(Type sourcePageType) in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\Frame\Frame.cs:line 444
        > at Windows.UI.Xaml.Controls.Frame.EnsurePageInitialized(PageStackEntry entry) in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\Frame\Frame.cs:line 435
        > at Windows.UI.Xaml.Controls.Frame.InnerNavigate(PageStackEntry entry, NavigationMode mode) in C:\a\1\s\src\Uno.UI\UI\Xaml\Controls\Frame\Frame.cs:line 283
        > --- End of managed Java.Lang.ClassNotFoundException stack trace ---
        > java.lang.ClassNotFoundException: crc643edf5f81ce7abab9.Segmented
        > 	at java.lang.Class.classForName(Native Method)
        > 	at java.lang.Class.forName(Class.java:454)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.n_onActivityStarted(Native Method)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.onActivityStarted(NativeApplication_ActivityCallbacks.java:99)
        > 	at android.app.Application.dispatchActivityStarted(Application.java:401)
        > 	at android.app.Activity.dispatchActivityStarted(Activity.java:1409)
        > 	at android.app.Activity.onStart(Activity.java:1948)
        > 	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:496)
        > 	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:246)
        > 	at crc6467d88aaa7548788d.BaseActivity.n_onStart(Native Method)
        > 	at crc6467d88aaa7548788d.BaseActivity.onStart(BaseActivity.java:611)
        > 	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1543)
        > 	at android.app.Activity.performStart(Activity.java:8367)
        > 	at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3669)
        > 	at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:224)
        > 	at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:204)
        > 	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
        > 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
        > 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2306)
        > 	at android.os.Handler.dispatchMessage(Handler.java:106)
        > 	at android.os.Looper.loopOnce(Looper.java:201)
        > 	at android.os.Looper.loop(Looper.java:288)
        > 	at android.app.ActivityThread.main(ActivityThread.java:7918)
        > 	at java.lang.reflect.Method.invoke(Native Method)
        > 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        > 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
        > Caused by: java.lang.ClassNotFoundException: Didn't find class "crc643edf5f81ce7abab9.Segmented" on path: DexPathList[[zip file "/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk"],nativeLibraryDirectories=[/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/lib/x86_64, /data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk!/lib/x86_64, /system/lib64, /system_ext/lib64]]
        > 	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        > 	... 26 more
        > --- End of managed Java.Lang.ClassNotFoundException stack trace ---
        > java.lang.ClassNotFoundException: crc643edf5f81ce7abab9.Segmented
        > 	at java.lang.Class.classForName(Native Method)
        > 	at java.lang.Class.forName(Class.java:454)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.n_onActivityStarted(Native Method)
        > 	at crc64122dcf5ad656876d.NativeApplication_ActivityCallbacks.onActivityStarted(NativeApplication_ActivityCallbacks.java:99)
        > 	at android.app.Application.dispatchActivityStarted(Application.java:401)
        > 	at android.app.Activity.dispatchActivityStarted(Activity.java:1409)
        > 	at android.app.Activity.onStart(Activity.java:1948)
        > 	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:496)
        > 	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:246)
        > 	at crc6467d88aaa7548788d.BaseActivity.n_onStart(Native Method)
        > 	at crc6467d88aaa7548788d.BaseActivity.onStart(BaseActivity.java:611)
        > 	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1543)
        > 	at android.app.Activity.performStart(Activity.java:8367)
        > 	at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3669)
        > 	at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:224)
        > 	at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:204)
        > 	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
        > 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
        > 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2306)
        > 	at android.os.Handler.dispatchMessage(Handler.java:106)
        > 	at android.os.Looper.loopOnce(Looper.java:201)
        > 	at android.os.Looper.loop(Looper.java:288)
        > 	at android.app.ActivityThread.main(ActivityThread.java:7918)
        > 	at java.lang.reflect.Method.invoke(Native Method)
        > 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        > 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
        > Caused by: java.lang.ClassNotFoundException: Didn't find class "crc643edf5f81ce7abab9.Segmented" on path: DexPathList[[zip file "/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk"],nativeLibraryDirectories=[/data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/lib/x86_64, /data/app/~~6pQFnZX-1E4rY07w1f_phw==/ToolkitPackageUwpUnoTest.ToolkitPackageUwpUnoTest-gZ5Gb9jmLleNqZsxdFVgkg==/base.apk!/lib/x86_64, /system/lib64, /system_ext/lib64]]
        > 	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        > 	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        > 	... 26 more

     </details>

.editorconfig

michael-hawker · 2023-08-15T17:39:07Z

Kicked off a new build, hopefully the package versioning stuff is all resolved, so we'll have a clean set of new packages to try soon! 🤞

michael-hawker · 2023-08-15T23:06:51Z

Build good, but have been having trouble with the uno template from VS on my machine, trying in VS Code now. Got this message from NuGet about the android package:

C:\temp\UnoTestApp\UnoTestApp\UnoTestApp.csproj : error NU1202: Package CommunityToolkit.WinUI.Controls.Primitives 8.0.230815-pull-173.526 is not compatible with ne
t7.0-android33.0 (.NETCoreApp,Version=v7.0). Package CommunityToolkit.WinUI.Controls.Primitives 8.0.230815-pull-173.526 supports: [C:\temp\UnoTestApp\UnoTestApp.Win
dows\UnoTestApp.Windows.csproj]

Do we have to be more specific than net7.0-android?

michael-hawker · 2023-08-15T23:30:07Z

Was able to test in VS Code from the command line with dotnet run that the WASM side of the WinUI Primitives package works fine! 🎉🎉🎉 Will see if I can get anything else working, maybe with XAML too.

michael-hawker · 2023-08-16T00:25:06Z

Tested the Uwp packages for both WinUI 2 and 3 for the Segmented control package in release mode, worked fine.

We can probably remove the all-uwp restriction from the WASDK build. Seems like things were fixed in 1.3. Means the only use of the packages is really between Uno.UI vs. Uno.WinUI for Uno Platform. Would make migrating easier for folks potentially as they can transform their UWP to WASDK without having to change the Toolkit packages just yet. We can just preface and say that things may change in the future type thing, as required and that eventually once Uno Platform stops support Uno.UI we'd only have the one package (unless we end up having to separate them again due to changes in WASDK/WinUI 3).

Arlodotexe · 2023-08-16T17:33:08Z

Do we have to be more specific than net7.0-android?

Found some useful information about how Uno handles net6 and net7 targets on Android: unoplatform/uno#11423
I've also reached out to Uno via the UWP Community Discord: https://discord.com/channels/372137812037730304/1139681165142396948/1141422502304821258

I'll switch us over to android33.0 for now and trying that while waiting for a reply.

michael-hawker · 2023-08-17T16:11:47Z

Looks like these are the last warnings hopefully:

D:\a\Windows\Windows\components\Animations\src\Enums\FrameworkLayer.cs(16,5): error CS1587: XML comment is not placed on a valid language element [D:\a\Windows\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj::TargetFramework=net7.0-android33.0]
         D:\a\Windows\Windows\components\Animations\src\Enums\FrameworkLayer.cs(12,5): error CS1587: XML comment is not placed on a valid language element [D:\a\Windows\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj::TargetFramework=net7.0-android33.0]
         D:\a\Windows\Windows\components\Animations\src\Enums\FrameworkLayer.cs(25,5): error CS1587: XML comment is not placed on a valid language element [D:\a\Windows\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj::TargetFramework=net7.0-android33.0]
         D:\a\Windows\Windows\components\Animations\src\Enums\FrameworkLayer.cs(21,5): error CS1587: XML comment is not placed on a valid language element [D:\a\Windows\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj::TargetFramework=net7.0-android33.0]
         D:\a\Windows\Windows\components\Animations\src\Xaml\Abstract\CustomAnimation{TValue,TKeyFrame}.cs(22,5): error CS1587: XML comment is not placed on a valid language element [D:\a\Windows\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj::TargetFramework=net7.0-android33.0]

michael-hawker

Small nit, and something to follow-up on later, but otherwise we should be good. Yay!

Did these not need to be addressed too though? #173 (comment)

.github/workflows/build.yml

components/Animations/src/Enums/FrameworkLayer.cs

Update tooling to latest upgrade/net7

Cleaned up some logic for diagnostic builds as well so we have a single build command

…ript

2023-08-17T20:08:53.7233918Z 5>D:\a\Windows\Windows\components\Behaviors\src\Notification\StackedNotificationsBehavior.cs(16,70): error CS1574: XML comment has cref attribute 'InfoBar' that could not be resolved

Arlodotexe added enhancement New feature or request Priority-1 ux 🖌️ Everything design related dev loop ➰ labels Aug 11, 2023

Arlodotexe requested a review from michael-hawker August 11, 2023 19:55

michael-hawker force-pushed the upgrade/net7 branch from 27e89fd to 5e19e64 Compare August 12, 2023 00:34

michael-hawker reviewed Aug 15, 2023

View reviewed changes

.editorconfig Outdated Show resolved Hide resolved

michael-hawker force-pushed the upgrade/net7 branch from 51386df to 4945f73 Compare August 15, 2023 18:35

michael-hawker mentioned this pull request Aug 16, 2023

Fixes issues with the build script in detecting dump files to upload and analyze #174

Merged

michael-hawker force-pushed the upgrade/net7 branch from c5eaae2 to 67751cc Compare August 17, 2023 16:08

Arlodotexe enabled auto-merge (rebase) August 17, 2023 17:24

Arlodotexe requested a review from michael-hawker August 17, 2023 17:24

michael-hawker approved these changes Aug 17, 2023

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

components/Animations/src/Enums/FrameworkLayer.cs Outdated Show resolved Hide resolved

Arlodotexe and others added 10 commits August 17, 2023 13:52

Fixed build errors caused by .NET 7 upgrade

4462127

Updated tooling pointer

7c09f83

Update tooling to latest upgrade/net7

Bump uno-check

89ae462

Skip vswinworkloads

7b28720

Update Build Script to support Pull Request Packages Again

9134bf8

Cleaned up some logic for diagnostic builds as well so we have a single build command

Update tooling to use maccatalyst

df2bf9f

Fix for net7.0-maccatalyst, use dotnet 7.0.100

73a1d00

Update tooling, additional net7-mobile error suppression

6fe3e9c

Update tooling: More error suppression for net7 mobile

1efcb48

Fixed invalid symbol references in comments

26d294a

Arlodotexe and others added 12 commits August 17, 2023 13:52

Update editorconfig

0724bef

Update editorconfig

44f957d

Update logic for Versioning of Build and ensure to pass to Packing Sc…

de0098b

…ript

Use net7.0-android33.0 instead of net7.0-android

7db369a

Fix and un-suppress CS1574 errors

6634997

Remove suppression of CS1587

e3bfa21

Update tooling pointer

f89d21f

Fixed remaining build errors

0dfb3d0

Update tooling to latest main

f498057

Suppress CS1587

f2d46f6

Move platfiorm conditionals to using statements

dacdaf7

Fix issue with XML comment for StackedNotificationsBehavior

7328b98

2023-08-17T20:08:53.7233918Z 5>D:\a\Windows\Windows\components\Behaviors\src\Notification\StackedNotificationsBehavior.cs(16,70): error CS1574: XML comment has cref attribute 'InfoBar' that could not be resolved

michael-hawker force-pushed the upgrade/net7 branch from 0f881a6 to 7328b98 Compare August 17, 2023 20:52

michael-hawker mentioned this pull request Aug 17, 2023

Add Package Signing and Release Staging/Pipeline for NuGet.org #178

Merged

michael-hawker disabled auto-merge August 17, 2023 20:54

michael-hawker enabled auto-merge (squash) August 17, 2023 20:55

michael-hawker merged commit 58cdd50 into main Aug 17, 2023
7 checks passed

delete-merged-branch bot deleted the upgrade/net7 branch August 17, 2023 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to .NET 7, enable WASM optimizations #173

Upgrade to .NET 7, enable WASM optimizations #173

Arlodotexe commented Aug 11, 2023

Arlodotexe commented Aug 11, 2023 •

edited

Loading

michael-hawker commented Aug 15, 2023

michael-hawker commented Aug 15, 2023

michael-hawker commented Aug 15, 2023

michael-hawker commented Aug 16, 2023

Arlodotexe commented Aug 16, 2023 •

edited

Loading

michael-hawker commented Aug 17, 2023

michael-hawker left a comment

Upgrade to .NET 7, enable WASM optimizations #173

Upgrade to .NET 7, enable WASM optimizations #173

Conversation

Arlodotexe commented Aug 11, 2023

Arlodotexe commented Aug 11, 2023 • edited Loading

michael-hawker commented Aug 15, 2023

michael-hawker commented Aug 15, 2023

michael-hawker commented Aug 15, 2023

michael-hawker commented Aug 16, 2023

Arlodotexe commented Aug 16, 2023 • edited Loading

michael-hawker commented Aug 17, 2023

michael-hawker left a comment

Choose a reason for hiding this comment

Arlodotexe commented Aug 11, 2023 •

edited

Loading

Arlodotexe commented Aug 16, 2023 •

edited

Loading