Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SettingsCard] Accesibility improvements #284

Merged
merged 13 commits into from
Jan 9, 2024

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Nov 28, 2023

This PR:


Wrong high contrast color (#283)
Before (issue #271):
image

After:
image

Before (issue #283):
image

After:
image

Before (issue #262)
Narrator: Focus on card title, group => click event doesn't work

After:
Narrator: Card title, button => click event works

@niels9001 niels9001 marked this pull request as ready for review November 28, 2023 11:15
@Arlodotexe Arlodotexe enabled auto-merge (rebase) January 9, 2024 17:49
auto-merge was automatically disabled January 9, 2024 18:57

Rebase failed

@Arlodotexe Arlodotexe merged commit 8285f8d into main Jan 9, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the niels9001/settingscard-a11y branch January 9, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants