Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting Helpers #41

Merged
merged 18 commits into from
May 4, 2023
Merged

Porting Helpers #41

merged 18 commits into from
May 4, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented May 1, 2023 •
edited
Loading

Issue: #17

Namespace: CommunityToolkit.WinUI.Helpers

  • ColorHelper
  • CompositionTargetHelper
  • ScreenUnitHelper
  • DesignTimeHelper
  • PackageVersionHelper
  • ThemeListener (still broken on WASDK)
  • WeakEventListener
  • NetworkHelper
  • Documentation + sample for ThemeListener

@niels9001 niels9001 marked this pull request as ready for review May 2, 2023 13:31
@Arlodotexe Arlodotexe enabled auto-merge May 2, 2023 16:13
@Arlodotexe Arlodotexe disabled auto-merge May 2, 2023 16:25
Arlodotexe
Arlodotexe approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions, otherwise lgtm!

components/Helpers/samples/Helpers.md Show resolved Hide resolved
components/Helpers/samples/ThemeListener.md Outdated Show resolved Hide resolved
components/Helpers/samples/WeakEventListener.md Outdated Show resolved Hide resolved
components/Helpers/src/CommunityToolkit.WinUI.Helpers.csproj Outdated Show resolved Hide resolved
@Arlodotexe Arlodotexe enabled auto-merge May 2, 2023 22:20
@niels9001 niels9001 disabled auto-merge May 3, 2023 08:04
@niels9001 niels9001 enabled auto-merge May 3, 2023 08:05
auto-merge was automatically disabled May 3, 2023 20:02

Merge queue setting changed

@niels9001 niels9001 merged commit f9de621 into main May 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/helpers-port branch May 4, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niels9001 @Arlodotexe