Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project files easier to read and understand #3896

Closed
5 tasks done
Nirmal4G opened this issue Mar 27, 2021 · 2 comments · Fixed by #3893
Closed
5 tasks done

Make project files easier to read and understand #3896

Nirmal4G opened this issue Mar 27, 2021 · 2 comments · Fixed by #3893
Labels
Completed 🔥 improvements ✨ optimization ☄ Performance or memory usage improvements
Milestone

Comments

@Nirmal4G
Copy link
Contributor

Nirmal4G commented Mar 27, 2021

It's hard to read and understand the repo (because of all the redundant files and confusing logic).
The following changes (although not exhaustive) would improve the contribution experience a little bit better.

  • Fix corrupted emojis and symbols
  • Fix-up white-spaces and new-lines
  • Remove un-necessary and duplicate logic
  • Rename missed files from previous renames
  • Fix Markdown tests with trailing white-spaces

I hope, these changes, along with the upcoming refactoring #3898 would definitely make this repo better for everyone.

@ghost ghost added the needs triage 🔍 label Mar 27, 2021
@ghost
Copy link

ghost commented Mar 27, 2021

Hello Nirmal4G, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the In-PR 🚀 label Mar 27, 2021
@Nirmal4G Nirmal4G changed the title Make project files easier to read Make project files easier to read and understand Mar 27, 2021
@ghost ghost removed the needs triage 🔍 label Mar 27, 2021
@Kyaa-dost Kyaa-dost added this to the 7.1 milestone May 14, 2021
@Kyaa-dost Kyaa-dost added the optimization ☄ Performance or memory usage improvements label May 14, 2021
@Nirmal4G
Copy link
Contributor Author

@michael-hawker @Sergio0694

It may seem like I'm changing things too much but is an incremental change (that's probably why it's hard to review since we can't see full picture yet) and part of a larger refactoring that'll make the codebase better for maintenance and contribution.

I could put all of my changes onto a single branch like @azchohfi did with his winui branch but it'll be harder to review. Even with the formatting and clean-up changes in a single PR, it was hard. So, I'll keep mutually exclusive changes in its own branch and PR.

My goal is to improve the quality of the codebase to be on par with the dotnet repos. I can see that there are people for the actual code of the Toolkit project but only one or two on the build/repo side of things. This is my way of helping to fill the gap.

@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Jun 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Completed 🔥 improvements ✨ optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants