-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings in HighPerformance/Mvvm unit tests #4142
Fix warnings in HighPerformance/Mvvm unit tests #4142
Conversation
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Cool want to fix the source generator ones too?
|
@michael-hawker I've re-run the .bat script to update headers and that didn't do anything. And the headers look fine to me too. This is kinda making me wonder whether it might be some weird result of the changes in #3896 where the BOM at the start of the files was removed, and whether that's somehow causing that warning in StyleCop. At the very least, the fact that running the script isn't fixing anything confirms that we don't really have the infrastructure in place to maintain those whitespace updates in those PRs I fear 😥 EDIT: mmh wait on second though those seem to just be generated files, which shouldn't really be inspected by StyleCop at all? They also have |
16218eb
to
6b03f8a
Compare
Hello @RosarioPulella! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes #4102 (comment)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some HighPerformance/Mvvm unit tests produce warnings when the projects are built.
What is the new behavior?
No more warnings 🙌
PR Checklist
Please check if your PR fulfills the following requirements: