Fix warnings in HighPerformance/Mvvm unit tests

[Sergio0694]

Fixes #4102 (comment)

PR Type

What kind of change does this PR introduce?

• Maintenance

What is the current behavior?

Some HighPerformance/Mvvm unit tests produce warnings when the projects are built.

What is the new behavior?

No more warnings 🙌

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

[ghost]

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[michael-hawker]

Cool want to fix the source generator ones too?

D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ICommandGenerator\UnitTests.Mvvm.Test_ICommandAttribute.MyViewModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.IMessengerRegisterAllGenerator\UnitTests.Mvvm.Test_IRecipientGenerator.RecipientWithSomeMessages.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.IMessengerRegisterAllGenerator\UnitTests.Mvvm.Test_Messenger.RecipientWithSomeMessages.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.INotifyPropertyChangedGenerator\UnitTests.Mvvm.Test_INotifyPropertyChangedAttribute.SampleModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.INotifyPropertyChangedGenerator\UnitTests.Mvvm.Test_INotifyPropertyChangedAttribute.SampleModelWithoutHelpers.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.INotifyPropertyChangedGenerator\UnitTests.Mvvm.Test_ObservablePropertyAttribute.DependentPropertyModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableObjectGenerator\UnitTests.Mvvm.Test_ObservableObjectAttribute.SampleModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableObjectGenerator\UnitTests.Mvvm.Test_ObservableObjectAttribute.SampleModelSealed.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator\UnitTests.Mvvm.Test_ObservablePropertyAttribute.SampleModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator\UnitTests.Mvvm.Test_ObservablePropertyAttribute.DependentPropertyModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator\UnitTests.Mvvm.Test_ObservablePropertyAttribute.MyFormViewModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator\__KnownINotifyPropertyChangedOrChangingArgs.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableRecipientGenerator\UnitTests.Mvvm.Test_ObservableRecipientAttribute.Person.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableRecipientGenerator\UnitTests.Mvvm.Test_ObservableRecipientAttribute.AbstractPerson.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableRecipientGenerator\UnitTests.Mvvm.Test_ObservableRecipientAttribute.NonAbstractPerson.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservablePropertyAttribute.MyFormViewModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservableRecipientAttribute.Person.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservableValidator.Person.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservableValidator.PersonWithDeferredValidation.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservableValidator.ComparableModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservableValidator.CustomValidationModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservableValidator.ValidationWithServiceModel.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]
         D:\a\1\s\UnitTests\UnitTests.NetCore\Microsoft.Toolkit.Mvvm.SourceGenerators\Microsoft.Toolkit.Mvvm.SourceGenerators.ObservableValidatorValidateAllPropertiesGenerator\UnitTests.Mvvm.Test_ObservableValidator.ValidationWithDisplayName.cs(1,1): warning SA1633: The file header XML is invalid. [D:\a\1\s\UnitTests\UnitTests.NetCore\UnitTests.NetCore.csproj]

[Sergio0694]

@michael-hawker I've re-run the .bat script to update headers and that didn't do anything. And the headers look fine to me too. This is kinda making me wonder whether it might be some weird result of the changes in #3896 where the BOM at the start of the files was removed, and whether that's somehow causing that warning in StyleCop. At the very least, the fact that running the script isn't fixing anything confirms that we don't really have the infrastructure in place to maintain those whitespace updates in those PRs I fear 😥

EDIT: mmh wait on second though those seem to just be generated files, which shouldn't really be inspected by StyleCop at all? They also have #pragma warning disable but it seems like it's not being respected? Will take a look 🤔

[ghost]

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.