Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListDetailsView runtime error in Store App when spawned from VS Debug hyperlink #4258

Closed
2 tasks
XAML-Knight opened this issue Sep 17, 2021 · 4 comments · Fixed by #4268
Closed
2 tasks

ListDetailsView runtime error in Store App when spawned from VS Debug hyperlink #4258

XAML-Knight opened this issue Sep 17, 2021 · 4 comments · Fixed by #4268
Assignees
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 sample app 🖼 sample bug 🐛
Milestone

Comments

@XAML-Knight
Copy link
Contributor

XAML-Knight commented Sep 17, 2021

Describe the bug

When reviewing a Toolkit Docs PR, encountered a runtime error, when loading the ListDetailsView in the Store App. This error was encountered when following a hyperlink in a VS Toolkit debug session (i.e., not from within the Store App itself), which spawned the Store App with ListDetailsView as a query string value. The hyperlink in question is in the Documentation section of a sample page (You can see this in action in the Windows Community Toolkit Sample App.). The Store App was not running - clicking the hyperlink launched the Store App.
image

image

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.)
    No - as a matter of fact, if another sample page in the Store App has already been loaded, this error is non-reproducible from within the Store App.

Steps to reproduce the behavior:

  1. Run the Toolkit in Visual Studio (v16.11.3, X64/Debug)
  2. Go to ListDetailsView
  3. Click on 'You can see this in action'
  4. See error in the Store App that has been launched

Expected behavior

Store App launches, no runtime errors occur, and user sees ListDetailsView

Screenshots

image

Environment

Visual Studio version 16.11.3 (X64/Debug)

Additional context

@XAML-Knight XAML-Knight added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ labels Sep 17, 2021
@ghost ghost added the needs triage 🔍 label Sep 17, 2021
@ghost
Copy link

ghost commented Sep 17, 2021

Hello XAML-Knight, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@michael-hawker
Copy link
Member

Yeah, we've seen this in the past, see #3788.

It's transient and weird though, as if I hit a key in the XAML view without changing the XAML, it loads and displays. There's some other oddity going on here somehow.

We can see if just removing the styles makes it more stable?

@michael-hawker
Copy link
Member

I tried locally changing them to StaticResource (not sure why they were ThemeResource), that worked the first time. Will keep an eye on it as I test sample app for the release.

@michael-hawker michael-hawker self-assigned this Sep 20, 2021
@michael-hawker
Copy link
Member

So far this switch has been working in my testing

@ghost ghost added the In-PR 🚀 label Sep 22, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Sep 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 sample app 🖼 sample bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants